Rewrite Message action links #20123
Merged
Rewrite Message action links #20123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinSchoeler
previously requested changes
Jan 15, 2021
There was a problem hiding this comment.
Bugs:
- No hover color change on message action links
- On pinned/starred messages the message action menu never goes away, possibly related to [BUG] starredMessages screen menu doesn't close #20184
- In Message auditing message actions don't work
ggazzo
force-pushed
the
rewrite/actionLinks
branch
from
3037ac8 to
cc8c40c
Compare
MartinSchoeler
approved these changes
Jan 16, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments