Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Omnichannel - Contact Center form is not validating custom fields properly #20196

Merged

Conversation

rafaelblink
Copy link
Contributor

@rafaelblink rafaelblink commented Jan 13, 2021

Proposed changes (including videos or screenshots)

The contact form is accepting undefined values in required custom fields when creating or editing contacts, and, the errror message isn't following Rocket.chat design system.

Before

image

After

New

image

Edit

image

Issue(s)

Steps to test or reproduce

Enter on Omnichannel Contact Center on left side menu > "New Contact" or Edit clicking on the row at the list grid.

Further comments

@rafaelblink rafaelblink changed the title [FIX] Contact form is not validating custom fields properly [FIX] Omnichannel - Contact form is not validating custom fields properly Jan 13, 2021
@rafaelblink rafaelblink changed the title [FIX] Omnichannel - Contact form is not validating custom fields properly [FIX] Omnichannel - Contact Center form is not validating custom fields properly Jan 13, 2021
@rafaelblink rafaelblink marked this pull request as ready for review January 14, 2021 14:45
@renatobecker renatobecker added this to the 3.11.0 milestone Jan 18, 2021
@renatobecker renatobecker merged commit 3adb7ac into develop Jan 18, 2021
@renatobecker renatobecker deleted the omnichannel/contact-center-custom-fields-validations branch January 18, 2021 12:11
@sampaiodiego sampaiodiego mentioned this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants