[FIX] - Cancel button on Room Notification don't close contextualBar #20237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ggazzo I feel that is missing the toast message when saving the notifications preferences, not just for visual consistency, even if we had some problem with the method, the toast message should return an error in a visual way. Do you think it's nice to work on this improvement? |
|
@dougfabris #20220 fixes that toast message issue:) |
|
@Darshilp326 Really nice! Thanks for your help =) |
tiagoevanp
previously approved these changes
Jan 21, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
closes #20220
Steps to test or reproduce
Further comments