Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Filters are not being applied correctly in Omnichannel Current Chats list #20320

Merged
merged 16 commits into from
Feb 2, 2021

Conversation

rafaelblink
Copy link
Contributor

@rafaelblink rafaelblink commented Jan 22, 2021

Proposed changes (including videos or screenshots)

After a few changes in previous releases, Current Chats page filter stopped working.

Before

image

After

image

image

image

Issue(s)

Steps to test or reproduce

Further comments

@rafaelblink rafaelblink marked this pull request as ready for review January 22, 2021 19:47
@rafaelblink rafaelblink added this to the 3.11.0 milestone Jan 22, 2021
@renatobecker
Copy link
Contributor

I've tested your code, but it doesn't fix the issue as you can see below:

Screen Shot 2021-01-26 at 3 58 51 PM
Screen Shot 2021-01-26 at 3 59 24 PM
Screen Shot 2021-01-26 at 3 59 33 PM

Copy link
Contributor

@renatobecker renatobecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also:

The first request sent from the client when the Current Chats list is opened looks like this:

{"t":"l","$or":[{"servedBy._id":{"$in":[""]}},{"servedBy.username":{"$in":[""]}}],"open":{"$exists":false}}

After that, when I set the first date parameter(From), the server gets this:

{"t":"l"}

And when a set the last date parameter(To) the server gets this:

{"t":"l","ts":{"$gte":"2021-01-26T03:00:00.000Z","$lte":"2021-01-26T03:00:00.000Z"}}

So, it's clear it won't work properly. Can you fix this, @rafaelblink ?
Thanks.

@renatobecker renatobecker modified the milestones: 3.11.0, 3.12.0 Feb 1, 2021
@renatobecker
Copy link
Contributor

@rafaelblink your PR didn't pass the tests.
Did you notice that?

@renatobecker renatobecker changed the title [FIX] Omnichannel Auto Complete component with wrong default value. [FIX] Filters are not being applied correctly in the current Omnichannel chat list Feb 2, 2021
@renatobecker renatobecker changed the title [FIX] Filters are not being applied correctly in the current Omnichannel chat list [FIX] Filters are not being applied correctly in Omnichannel Current Chats list Feb 2, 2021
@renatobecker renatobecker merged commit 61ca8bf into develop Feb 2, 2021
@renatobecker renatobecker deleted the omnichannel/departments-auto-complete-fix branch February 2, 2021 18:25
@sampaiodiego sampaiodiego mentioned this pull request Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants