Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Feedback on bulk invite #20339

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Conversation

aKn1ghtOut
Copy link
Contributor

Checklist

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Resolved structure where no response was being received. Changed from callback to async/await.
Added error in case of empty submission, or if no valid emails were found.

gitIssueBulkInvite-2021-01-24_02.24.08.mp4

Issue(s)

Closes #19021

Steps to test or reproduce

  1. Open administration
  2. Invite by email addresses
  3. Submit invalid or empty email input [ No error ]
  4. No feedback at all on submission

Further comments

@aKn1ghtOut
Copy link
Contributor Author

@dougfabris @ggazzo Please review

@dougfabris
Copy link
Member

dougfabris commented Jan 26, 2021

@aKn1ghtOut Really nice fix, thank you! I think, to be perfect, we should add a UI validation to prevent the user to send a request with the field empty or even an invalid email.

@yash-rajpal
Copy link
Member

yash-rajpal commented Jan 26, 2021

@dougfabris my PR #20337 already adds the button disable check, Please review that PR for this functionality. Thanks.

@dougfabris
Copy link
Member

@yash-rajpal Really nice, thanks for notifying!

@yash-rajpal
Copy link
Member

yash-rajpal commented Jan 26, 2021

@dougfabris No problem :). Please tell if that PR requires any changes.
Thanks.

@dougfabris dougfabris requested a review from ggazzo January 26, 2021 12:45
@ggazzo ggazzo merged commit 88f6c00 into RocketChat:develop Feb 2, 2021
@sampaiodiego sampaiodiego mentioned this pull request Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: No feedback messages when inviting users from Administration -> Users -> Invite
4 participants