Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Fixed update room avatar issue. #20433

Merged
merged 2 commits into from
Jan 30, 2021
Merged

Regression: Fixed update room avatar issue. #20433

merged 2 commits into from
Jan 30, 2021

Conversation

Darshilp326
Copy link
Contributor

Proposed changes (including videos or screenshots)

Users can now update their room avatar without any error.

update-room-avatar-pr.mp4

Issue(s)

Closes #20432

Steps to test or reproduce

Further comments

@Darshilp326
Copy link
Contributor Author

@dougfabris @lolimay Please review:)

@dougfabris dougfabris changed the title [FIX]Fixed update room avatar issue. [FIX] Fixed update room avatar issue. Jan 28, 2021
@dougfabris
Copy link
Member

@Darshilp326 I think we have a bug after change the room avatar, the room doesn't change the image properly in roomInfo, in the thumbnail of the room and in the sidebar. Would be amazing to fix that. Can you check for us?

@shiqimei shiqimei requested a review from d-gubert January 28, 2021 14:49
@yash-rajpal yash-rajpal mentioned this pull request Jan 28, 2021
Open
6 tasks
@yash-rajpal
Copy link
Member

@dougfabris I looked into it. If any room uses default room avatar, then there is no avatarEtag in its room object. This property makes up the avatar url so that it can be displayed.
When we edit the room avatar, avatar etag property is attached to room object. I think this prop is being attached after some time because in my testing after sometime this prop came in object automatically after 20 mins, or something is happening due to which this property is not added immediately.
So everytime we need to show the room avatar, we can fetch room details using room id and then show avatar.
I have made a PR regarding this #20479. Please take a look at it.

@Darshilp326
Copy link
Contributor Author

@dougfabris Sure, I will be working on that issue.

@yash-rajpal yash-rajpal mentioned this pull request Jan 29, 2021
Closed
@shiqimei shiqimei mentioned this pull request Jan 29, 2021
Closed
@d-gubert d-gubert added this to the 3.11.0 milestone Jan 29, 2021
@d-gubert d-gubert changed the title [FIX] Fixed update room avatar issue. Regression: Fixed update room avatar issue. Jan 29, 2021
@ggazzo ggazzo merged commit 6e3a36c into RocketChat:develop Jan 30, 2021
@sampaiodiego sampaiodiego mentioned this pull request Feb 1, 2021
Merged
@aditya-mitra
Copy link
Contributor

I looked into it. If any room uses default room avatar, then there is no avatarEtag in its room object. This property makes up the avatar url so that it can be displayed.
When we edit the room avatar, avatar etag property is attached to room object. I think this prop is being attached after some time because in my testing after sometime this prop came in object automatically after 20 mins, or something is happening due to which this property is not added immediately.
So everytime we need to show the room avatar, we can fetch room details using room id and then show avatar.
I have made a PR regarding this #20479. Please take a look at it.

@yash-rajpal Are you still working on this issue? If you don't mind, I have a fix which might resolve the problem pointed out in the comment in #20479

@yash-rajpal
Copy link
Member

yash-rajpal commented Feb 2, 2021 •
edited
Loading

@aditya-mitra I am still working on it. It would be nice if you can share the fix, I also have some idea regarding it.

vanhoang1107 pushed a commit to vanhoang1107/Rocket.Chat that referenced this pull request Feb 5, 2021
Merge remote-tracking branch 'rocketchat/master'
99a6ed6 
* rocketchat/master: (133 commits)
  Bump version to 3.11.0
  Bump version to 3.11.0-rc.7
  Bump version to 3.11.0-rc.6
  Regression: Set image sizes based on rotation (RocketChat#20531)
  Regression: Apps-Engine - Convert streams to buffers on file upload (RocketChat#20523)
  Regression: Room not scrolling to bottom (RocketChat#20516)
  Regression: NPS (RocketChat#20514)
  Regression: Fix e2e paused state (RocketChat#20511)
  Regression: Custom field labels are not displayed properly on Omnichannel Contact Profile form (RocketChat#20393)
  Bump version to 3.11.0-rc.5
  Regression: Fix banners sync data types (RocketChat#20517)
  Regression: Fixed update room avatar issue.  (RocketChat#20433)
  Regression: ESLint Warning - explicit-function-return-type (RocketChat#20434)
  Bump version to 3.11.0-rc.4
  [FIX][Apps] Don't show the "review permissions" modal when there's none to review (RocketChat#20506)
  Revert "[NEW][ENTERPRISE] Hide message history for new channel members (RocketChat#20253)" (RocketChat#20461)
  Update Apps-Engine and permissions translations (RocketChat#20491)
  Regression: Add tests to new banners REST endpoints (RocketChat#20492)
  [IMPROVE] Autofocus on directory (RocketChat#20509)
  Update "Industry" setting (RocketChat#20510)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-gubert d-gubert d-gubert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.

[BUG] Room avatar cannot be updated.
6 participants
@Darshilp326 @dougfabris @yash-rajpal @aditya-mitra @d-gubert @ggazzo