Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVE] Added key prop, removing unwanted warnings #20473

Merged
merged 1 commit into from
Feb 2, 2021
Merged

[IMPROVE] Added key prop, removing unwanted warnings #20473

merged 1 commit into from
Feb 2, 2021

Conversation

yash-rajpal
Copy link
Member

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Removes warnings listed on the issue

Issue(s)

fixes #20472

Steps to test or reproduce

Further comments

@ggazzo ggazzo requested a review from a team February 2, 2021 01:55
@ggazzo ggazzo merged commit e8f15cf into RocketChat:develop Feb 2, 2021
@sampaiodiego sampaiodiego mentioned this pull request Feb 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning in console on opening userDropdown
2 participants
@yash-rajpal @ggazzo