-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] OEmbedURLWidget - Show Full Embedded Text Description #20569
[FIX] OEmbedURLWidget - Show Full Embedded Text Description #20569
Conversation
This resolves the problem for both (URL embeds and bot message embeds) because all bot message text embeds are by default url embeds. It can be found here in this file - /app/oembed/client/baseWidget.js This pull request is open for review. |
Please note that this doesn't fully fix everything outlined in #20556. The large padding on embeds is also an issue. |
@wreiske Did you mean the block quotes? |
Sorry, I meant the field objects on the embeds. See all of the extra padding? |
57230fb
to
bb208d3
Compare
bb208d3
to
3c6ade5
Compare
@ggazzo This Pull Request is open for review. |
Proposed changes (including videos or screenshots)
Embeds were cutoff when either urls had a long description.
This was handled by removing
overflow:hidden;text-overflow:ellipsis;
from the inline styles inoembedUrlWidget.html
.Earlier
Now
Issue(s)
Closes #20628
Steps to test or reproduce
Make sure the description of the link is long. Try
https://95nyn.csb.app/
orhttps://github.com
.Further comments
This is not related to Issue #20556