Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] OEmbedURLWidget - Show Full Embedded Text Description #20569

Merged
merged 2 commits into from
Mar 22, 2021

Conversation

aditya-mitra
Copy link
Contributor

@aditya-mitra aditya-mitra commented Feb 2, 2021

Proposed changes (including videos or screenshots)

Embeds were cutoff when either urls had a long description.
This was handled by removing overflow:hidden;text-overflow:ellipsis; from the inline styles in oembedUrlWidget.html.

Earlier

earlier

Now

now

Issue(s)

Closes #20628

Steps to test or reproduce

  • Send a link to any channel (or direct message)
    Make sure the description of the link is long. Try https://95nyn.csb.app/ or https://github.com.
  • You will find that the text

Further comments

This is not related to Issue #20556

@aditya-mitra
Copy link
Contributor Author

This resolves the problem for both (URL embeds and bot message embeds) because all bot message text embeds are by default url embeds. It can be found here in this file - /app/oembed/client/baseWidget.js

This pull request is open for review.
Thank you.

@wreiske
Copy link
Contributor

wreiske commented Feb 2, 2021

Please note that this doesn't fully fix everything outlined in #20556. The large padding on embeds is also an issue.

@aditya-mitra
Copy link
Contributor Author

@wreiske Did you mean the block quotes?
I was unable to notice them. Could help me by pointing them out?
I will come up with a fix as soon as possible.
Thank you.

@wreiske
Copy link
Contributor

wreiske commented Feb 4, 2021

@wreiske Did you mean the block quotes?
I was unable to notice them. Could help me by pointing them out?
I will come up with a fix as soon as possible.
Thank you.

Sorry, I meant the field objects on the embeds.
image

See all of the extra padding?

@aditya-mitra aditya-mitra force-pushed the aditya-mitra-embeds-wrap branch from bb208d3 to 3c6ade5 Compare February 6, 2021 06:14
@aditya-mitra
Copy link
Contributor Author

aditya-mitra commented Feb 6, 2021

@ggazzo This Pull Request is open for review.
Thank you.

@aditya-mitra aditya-mitra changed the title [FIX] Show Full OEmbed Text [FIX] OEmbeds - Show Full Embedded Text Feb 6, 2021
@aditya-mitra aditya-mitra changed the title [FIX] OEmbeds - Show Full Embedded Text [FIX] OEmbedURLWidget - Show Full Embedded Text Description Feb 6, 2021
@ggazzo ggazzo merged commit cf917ec into RocketChat:develop Mar 22, 2021
@sampaiodiego sampaiodiego mentioned this pull request Apr 3, 2021
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] URL OEmbeds are cut off
4 participants