Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Change header based on room type #20612

Merged
merged 6 commits into from
Feb 5, 2021
Merged

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Feb 4, 2021

closes #20609
closes #20197

Proposed changes (including videos or screenshots)

It brings more flexibility, allowing us to use different hooks and different components for each header

Issue(s)

Steps to test or reproduce

Further comments

@dougfabris dougfabris closed this Feb 4, 2021
@dougfabris dougfabris deleted the individual_headers branch February 4, 2021 21:32
@dougfabris dougfabris restored the individual_headers branch February 4, 2021 21:33
@dougfabris dougfabris reopened this Feb 4, 2021
@dougfabris dougfabris linked an issue Feb 4, 2021 that may be closed by this pull request
@ggazzo ggazzo changed the title chore: Change header based on room type [IMPROVE] Room Header Component based on room type Feb 5, 2021
@ggazzo ggazzo changed the title [IMPROVE] Room Header Component based on room type [IMPROVE] Change header based on room type Feb 5, 2021
@ggazzo ggazzo requested a review from a team February 5, 2021 02:53
@ggazzo ggazzo added this to the 3.12.0 milestone Feb 5, 2021
@ggazzo ggazzo merged commit b546bc9 into develop Feb 5, 2021
@ggazzo ggazzo deleted the individual_headers branch February 5, 2021 03:19
@aditya-mitra
Copy link
Contributor

@dougfabris Just a question.
If the user is offline, then the user-status-text won't be visible in the room header.
Shouldn't that be covered?

@dougfabris
Copy link
Member Author

@dougfabris Just a question.
If the user is offline, then the user-status-text won't be visible in the room header.
Shouldn't that be covered?

@aditya-mitra showing the default status under the name was a bug. The correct behavior is just to show custom status. It was already fixed.

@sampaiodiego sampaiodiego mentioned this pull request Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User's Custom Statuses no longer displayed in Direct Chat
4 participants