[FIX] Gif images aspect ratio on preview #20654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggazzo
approved these changes
Feb 9, 2021
sampaiodiego
pushed a commit
that referenced
this pull request
Feb 10, 2021
Merged
sampaiodiego
pushed a commit
that referenced
this pull request
Feb 10, 2021
vanhoang1107
pushed a commit
to vanhoang1107/Rocket.Chat
that referenced
this pull request
Feb 19, 2021
* rocketchat/master: Bump version to 3.11.1 [FIX] Livechat bridge permission checkers (RocketChat#20653) Fix room not being assigned to bot agent first. (RocketChat#20662) [FIX] Attachment download from title fixed (RocketChat#20585) [FIX] Gif images aspect ratio on preview (RocketChat#20654) [FIX] Update NPS banner when changing score (RocketChat#20611)
Merged
|
This still appears to be broken as of 3.18.1. Everything is subject to that Edit: Looks like I'm wrong about the max-width affecting this as I use the site-inspector to modify a bunch of those css values and the gifs in my rocketchat continued having a completely wrong and skewed ratio. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
closes #20546
closes #20307
Steps to test or reproduce
Further comments