[Fix] Broken useEffect opened new BBB Tab twice #20770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tiagoevanp & @ggazzo could you please review this? 🚀 |
|
Refs #20944 |
ggazzo
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19778 has a little Bug in the useEffect Hook. When you set the Setting "Open in the new Window" to true, a new tab gets opened every time you click on the call button. The intended usage should be that a new tab only opens when you click the join button.
Furthermore, when you start a BBB Meeting, two new tabs get opened due to the broken useEffect.
See the gif:
I added an Or with the openNewWindow Setting to the Conditional to break out of useEffect and not call startCall().
This fixed the issue for the openNewWindow Setting and kept the iFrame Integration as it is.
closes #20944