[FIX] System messages triggering when values don't change. #20845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevLehman
requested changes
Apr 30, 2021
| @@ -129,12 +129,14 @@ const settingSavers = { | |||
| saveRoomName(rid, value, user); | |||
| }, | |||
| roomTopic({ value, room, rid, user }) { | |||
| if (value !== room.topic) { | |||
| // room inits with room.topic as undefined. If value is empty string while room.topic is still undefined, do not set topic. | |||
| if (value !== room.topic && (value || room.topic)) { | |||
There was a problem hiding this comment.
This may fail if you explicitly set the room topic as '' (like, when you remove the topic at all)
The same will happens for the rest of the comparisons
Maybe a direct check for null or undefined would be better here?
|
|
gabriellsh
changed the title
|
Closing since requested changes weren't addressed. This will be implemented in a separate PR and will be linked here shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
#19038
Steps to test or reproduce
Further comments