Regression: Fix scopes not being provided to getWorkspaceAccessToken #20871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-gubert
approved these changes
Feb 23, 2021
Merged
vanhoang1107
pushed a commit
to vanhoang1107/Rocket.Chat
that referenced
this pull request
Mar 2, 2021
* rocketchat/master: (134 commits) Bump version to 3.12.0 Bump version to 3.12.0-rc.4 Revert config ignoreUndefined Bump version to 3.12.0-rc.3 Fix lint Security Fixes Bump version to 3.12.0-rc.2 [FIX] Admin Panel pages not visible in Safari (RocketChat#20912) Update Apps-Engine version (RocketChat#20921) Regression: Messages not being encrypted E2E (RocketChat#20922) Fix: Add network observe plug to snap (RocketChat#20852) Language update from LingoHub 🤖 (RocketChat#20853) Added types to Emitters (RocketChat#20819) Bump version to 3.12.0-rc.1 Regression: Fix scopes not being provided to getWorkspaceAccessToken (RocketChat#20871) Regression: Keep user custom status after change presence (RocketChat#20869) [FIX] Markdown prop variants (RocketChat#20767) [FIX] Open Visitor Info when omnichannel chat was open (RocketChat#20868) Regression: Prevent Message Attachment rendering (RocketChat#20860) [FIX] Download buttons on desktop app and CDN being ignored (RocketChat#20820) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
#20838 changed the getter.. didn't test full register process and missed this.
Issue(s)
Steps to test or reproduce
Further comments