Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Add markdown to custom fields in user Info #20947

Merged
merged 4 commits into from
Oct 8, 2021

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Mar 1, 2021

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Added markdown to custom fields to render links

Issue(s)

Fixes #20005

Steps to test or reproduce

Further comments

Before

image

After

image

@ankar84
Copy link

ankar84 commented Mar 17, 2021

Hey, @ggazzo @tassoevan @MartinSchoeler
Please take a review of that simple but very useful PR
Thanks!

@yash-rajpal
Copy link
Member Author

@ggazzo Please review.

@ankar84
Copy link

ankar84 commented Mar 23, 2021

Can you also fix that issue #19259 where long string in custom field is replaced with ... ?

@yash-rajpal yash-rajpal requested a review from ggazzo March 23, 2021 20:26
@ankar84
Copy link

ankar84 commented Apr 22, 2021

Hey, @ggazzo
Can you please review that PR to include it in 3.14?
Thanks!

@ggazzo ggazzo merged commit 7e4f8f2 into RocketChat:develop Oct 8, 2021
@sampaiodiego sampaiodiego mentioned this pull request Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Links in Custom Fields
4 participants