[IMPROVE] The icons in the message box have a transition of color change and zoom on hovering #21106
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -144,6 +144,12 @@ | |
| & .rc-input__icon-svg--plus { | ||
| transition: transform 0.1s linear; | ||
| } | ||
| &:hover, | ||
| &:focus, | ||
| &.active { | ||
| color: red; | ||
| transform: scale(1.5); | ||
|
There was a problem hiding this comment. I don't think its a good idea to use scaling property, It doesn't go well with UI/UX. This is just my opinion. Other places we are doing linear transform, maybe we can do something like that. There was a problem hiding this comment. We can use linear transform too, but here we would like to keep the time for transition very small, so that's why I used scaling property. There was a problem hiding this comment. Hey @yash-rajpal, |
||
| } | ||
| } | ||
|
|
||
| &__action-menu { | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't use a static red color, this doesn't go well with the design. Also we have dynamic colors, I mean, user can change colors of UI elements, so we should not provide static color values, instead do it like this. The variable
message-box-markdown-hover-colorcontains the color selected by user.