Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Show a consistent name on information screen #21603

Merged
merged 7 commits into from
Nov 6, 2022

Conversation

sumukhah
Copy link
Contributor

The current app shows Room Information for rooms but Team's Information from teams. This PR changed Team's Information to Team Information to maintain consistency

Current app

Screenshot 2021-04-16 at 4 23 22 PMScreenshot 2021-04-16 at 4 22 58 PM

After Change
Screenshot 2021-04-16 at 4 28 35 PM

Proposed changes (including videos or screenshots)

Consistent Naming

Issue(s)

Steps to test or reproduce

Further comments

@CLAassistant
Copy link

CLAassistant commented Dec 17, 2021

CLA assistant check
All committers have signed the CLA.

@ggazzo ggazzo added this to the 5.4.0 milestone Nov 2, 2022
@dougfabris dougfabris changed the title [Fix]Show a consistent name on information screen [FIX] Show a consistent name on information screen Nov 3, 2022
@dougfabris dougfabris added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Nov 3, 2022
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Nov 4, 2022
@ggazzo ggazzo merged commit 05298f5 into RocketChat:develop Nov 6, 2022
MartinSchoeler pushed a commit that referenced this pull request Nov 28, 2022
Co-authored-by: dougfabris <devfabris@gmail.com>
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@ggazzo ggazzo mentioned this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
communityPR stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants