-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] The parent room icon is now clickable #21655
Conversation
Not able to reproduce on our open as well as the local server. |
@Darshilp326 if we click on the parent room name then it redirects it to the room , but placing your cursor on the icon , the cursor shows it to be pointer type ,but it does not redirect you to the room |
@juliajforesti please check this I dont think link inside link is the best approach |
Codecov Report
@@ Coverage Diff @@
## develop #21655 +/- ##
===========================================
+ Coverage 40.89% 41.27% +0.37%
===========================================
Files 854 817 -37
Lines 18751 17881 -870
Branches 2053 1988 -65
===========================================
- Hits 7669 7380 -289
+ Misses 10791 10217 -574
+ Partials 291 284 -7
Flags with carried forward coverage won't be shown. Click here to find out more. |
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
Proposed changes (including videos or screenshots)
The parent room icon as shown in the video was not clickable but the cursor type on the icon was a pointer. Now even clicking on the icon or anywhere on the parent room tag will redirect you to the parent room.
Before :
Untitled.project.Made.with.Clipchamp.2.mp4
After:
Untitled.project.Made.with.Clipchamp.3.mp4
Issue(s)
Steps to test or reproduce
Further comments