Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] The parent room icon is now clickable #21655

Merged
merged 7 commits into from
Nov 21, 2022
Merged

[FIX] The parent room icon is now clickable #21655

merged 7 commits into from
Nov 21, 2022

Conversation

shrinish123
Copy link
Contributor

Proposed changes (including videos or screenshots)

The parent room icon as shown in the video was not clickable but the cursor type on the icon was a pointer. Now even clicking on the icon or anywhere on the parent room tag will redirect you to the parent room.

Before :

Untitled.project.Made.with.Clipchamp.2.mp4

After:

Untitled.project.Made.with.Clipchamp.3.mp4

Issue(s)

Steps to test or reproduce

Further comments

@Darshilp326
Copy link
Contributor

Not able to reproduce on our open as well as the local server.

@shrinish123
Copy link
Contributor Author

@Darshilp326 if we click on the parent room name then it redirects it to the room , but placing your cursor on the icon , the cursor shows it to be pointer type ,but it does not redirect you to the room

@CLAassistant
Copy link

CLAassistant commented Dec 17, 2021

CLA assistant check
All committers have signed the CLA.

@ggazzo ggazzo changed the title [IMPROVE] The parent room icon is now clickable [FIX] The parent room icon is now clickable Nov 2, 2022
@ggazzo ggazzo added this to the 5.4.0 milestone Nov 2, 2022
@ggazzo
Copy link
Member

ggazzo commented Nov 2, 2022

@juliajforesti please check this I dont think link inside link is the best approach

@juliajforesti juliajforesti requested a review from a team as a code owner November 17, 2022 18:18
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #21655 (ce74c08) into develop (1c5f950) will increase coverage by 0.37%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #21655      +/-   ##
===========================================
+ Coverage    40.89%   41.27%   +0.37%     
===========================================
  Files          854      817      -37     
  Lines        18751    17881     -870     
  Branches      2053     1988      -65     
===========================================
- Hits          7669     7380     -289     
+ Misses       10791    10217     -574     
+ Partials       291      284       -7     
Flag Coverage Δ
e2e 41.27% <ø> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Nov 17, 2022
@ggazzo ggazzo merged commit 595e8c5 into RocketChat:develop Nov 21, 2022
MartinSchoeler pushed a commit that referenced this pull request Nov 28, 2022
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
MartinSchoeler pushed a commit that referenced this pull request Nov 28, 2022
Co-authored-by: juliajforesti <juliajforesti@gmail.com>
@ggazzo ggazzo mentioned this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
communityPR stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants