[IMPROVE] Preview message URLs only once #22516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a message lists the same URL twice, the URL would be previewed twice.
This includes Markdown code explicitly using the URL as the link text.
e.g.
```
[http://example.com/](http://example.com/)
```
Strip out duplicate URLs when parsing them out,so we only show
a single preview.
Co-authored-by: Evgeniy Kulesh <evgeniyk@seekingalpha.com>
nmagedman
force-pushed
the
noach_preview_message_urls_only_once
branch
from
a2ab963 to
52fc6d1
Compare
ggazzo
approved these changes
Jul 1, 2021
gabriellsh
added a commit
that referenced
this pull request
Jul 1, 2021
…ite/create_disc * 'develop' of github.com:RocketChat/Rocket.Chat: (27 commits) [IMPROVE] Preview message URLs only once (#22516) [FIX] Admin page crashing when commit hash is null (#22057) [FIX] Unnecessary space on members list footer (#22514) Chore: Review some dependencies (#22522) Chore: Meteor 2.2 and bump dependencies (#22399) Chore: Remove Sodium from the main client (#22459) [FIX] Prune messages from particular user(s) (#22506) [FIX] Livechat apps permission error (#22511) [IMPROVE] Message deletion modal #22508 Update README.md Update README.md [IMPROVE] Add pagination to tags, and improve current Agents pagination [FIX] Rewrite CurrentChats to TS (#22424) [FIX] Sort AutocompleteDepartmentsMultiple (#22419) [FIX] Put title into AutocompleteDepartment components (#22417) [FIX] Bugs in AutoCompleteDepartment (#22414) [FIX] Closed chats doesn't show who picked the call (#22368) [FIX] Omnichannel Real Time Monitoring chart not displaying chats-per-agent and chats-per-department (#22406) [IMPROVE] Paginated multiselect for EE tags (#22315) [FIX] Units Edit and adds the option to hide own department in useDepartmentList ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a message lists the same URL twice, the URL would be previewed twice.
This includes Markdown code explicitly using the URL as the link text.
e.g.
[http://example.com/](http://example.com/)Strip out duplicate URLs when parsing them out, so we only show a single preview.