Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] crush in the getChannelHistory method #22667

Merged
merged 2 commits into from
Jul 19, 2021

Conversation

MaestroArt
Copy link
Contributor

There is a typo in the 56 line. I've added 'hiddenMessageTypes'.
How to reproduce:

  • call getChannelHistory method with 'oldest' param.

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

There is a typo in the 56 line. I've added 'hiddenMessageTypes'.
How to reproduce:
- call getChannelHistory method with 'oldest' param.
@MaestroArt MaestroArt marked this pull request as draft July 14, 2021 08:24
@MaestroArt MaestroArt closed this Jul 14, 2021
@MaestroArt MaestroArt reopened this Jul 14, 2021
@MaestroArt MaestroArt marked this pull request as ready for review July 14, 2021 08:27
@johncrisp
Copy link

Thanks you for this.

The Product Team are looking at this. Can you update your branch please?

@pierre-lehnen-rc pierre-lehnen-rc merged commit 48da604 into RocketChat:develop Jul 19, 2021
gabriellsh added a commit that referenced this pull request Jul 20, 2021
…improve/discussion-listimprove/discussion-listimprove/discussion-listimprove/discussion-listimprove/discussion-listimprove/discussion-listimprove/discussion-listimprove/discussion-listimprove/discussion-listimprove/discussion-listimprove/discussion-listimprove/discussion-listimprove/discussion-listimprove/discussion-listimprove/discussion-listimprove/discussion-listimprove/discussion-listimprove/discussion-listMerge branch 'develop' of github.com:RocketChat/Rocket.Chat into fix/attachment_emoji

* 'develop' of github.com:RocketChat/Rocket.Chat: (119 commits)
  [IMPROVE] Configuration for indices in Apps-Engine models (#22705)
  [FIX] Use room's last message time when visitor did not send any message (#22695)
  F room doesnt exists error when uploading file as first message (#22590)
  [IMPROVE] Refactor `livechat.registerGuest` function (#22684)
  change livechat_enabled default value to true (#22697)
  Chore: added pagination to search msg endpoint (#22632)
  Fixed crush in the getChannelHistory method (#22667)
  Regression: Fix ee microservices build (#22656)
  [IMPROVE] Rewrite sidebar footer as React Component (#22687)
  [FIX] Livechat config endpoint is not returning all settings (#22686)
  [FIX] Info page - Instances card modal table width #22627
  Bump version to 3.16.3
  fixed - room still listed after delete (#22613)
  Chore: Use projection instead of fields to avoid error log (#22629)
  [FIX] VisitorClientInfo not showing (#22593)
  Create README.md (#22615)
  [NEW] REST endpoint to remove User from Role (#20485)
  Bump version to 3.16.2
  Regression: Change the name of called methods in Users model (#22620)
  [FIX] Markdown for UiKit blocks (#22619)
  ...
gabriellsh added a commit that referenced this pull request Jul 20, 2021
…status-message

* 'develop' of github.com:RocketChat/Rocket.Chat: (114 commits)
  [FIX] Remove team's related actions inside of discussion #22470
  [IMPROVE] Configuration for indices in Apps-Engine models (#22705)
  [FIX] Use room's last message time when visitor did not send any message (#22695)
  F room doesnt exists error when uploading file as first message (#22590)
  [IMPROVE] Refactor `livechat.registerGuest` function (#22684)
  change livechat_enabled default value to true (#22697)
  Chore: added pagination to search msg endpoint (#22632)
  Fixed crush in the getChannelHistory method (#22667)
  Regression: Fix ee microservices build (#22656)
  [IMPROVE] Rewrite sidebar footer as React Component (#22687)
  [FIX] Livechat config endpoint is not returning all settings (#22686)
  [FIX] Info page - Instances card modal table width #22627
  Bump version to 3.16.3
  fixed - room still listed after delete (#22613)
  Chore: Use projection instead of fields to avoid error log (#22629)
  [FIX] VisitorClientInfo not showing (#22593)
  Create README.md (#22615)
  [NEW] REST endpoint to remove User from Role (#20485)
  Bump version to 3.16.2
  Regression: Change the name of called methods in Users model (#22620)
  ...
@ggazzo ggazzo mentioned this pull request Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants