Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Environmental variable for marketplace url #22922

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

graywolf336
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@graywolf336 graywolf336 marked this pull request as ready for review August 31, 2021 16:32
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it need to be documented somewhere? otherwise lgtm

@graywolf336
Copy link
Contributor Author

@sampaiodiego it doesn't. This is primarily for internal usage and specifically for Marketplace's staging environment so that we can test everything before we release to production.

@sampaiodiego sampaiodiego merged commit ee17501 into develop Sep 1, 2021
@sampaiodiego sampaiodiego deleted the customize-marketplace-endpoint branch September 1, 2021 20:32
@sampaiodiego sampaiodiego mentioned this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants