New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] 404 error when creating direct room for the first time #22944

Merged

dougfabris merged 3 commits into develop from fix/new-room-404

Aug 18, 2021

Member

dougfabris commented Aug 16, 2021 •

edited

Loading

Proposed changes (including videos or screenshots)

before

after

Issue(s)

Closes #22938
Closes #22256

Steps to test or reproduce

Further comments


          fix: race condition when creating room for the first time

7b71e3a

dougfabris requested review from ggazzo and a team

August 16, 2021 21:48

ankar84 commented Aug 17, 2021 •

edited

Loading

I guess it is a fix for #22256 and #22938


          fix: review

ef0ec3c

ggazzo approved these changes

View reviewed changes


          Merge branch 'develop' into fix/new-room-404

3fbc7eb

Member Author

dougfabris commented Aug 17, 2021

I guess it is a fix for #22256 and #22938

Thanks a lot @ankar84

dougfabris added this to the 3.18 milestone

dougfabris added the stat: ready to merge label

dougfabris merged commit 23fb89c into develop

dougfabris deleted the fix/new-room-404 branch

August 18, 2021 12:58

ankar84 mentioned this pull request

Direct messages: Create new direct message leads to 404 #22971

Closed

ankar84 mentioned this pull request

Starting a new direct message gives "unknown user" error RocketChat/Rocket.Chat.Electron#2241

Closed

ankar84 mentioned this pull request

E11000 duplicate key errors #24175

Open

ankar84 mentioned this pull request

Cannot open room with new LDAP user #24669

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge