-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Startup Time #23210
Chore: Startup Time #23210
Conversation
This pull request introduces 1 alert and fixes 1 when merging dd8f7b3 into 5443be7 - view on LGTM.com new alerts:
fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure what exactly is broken, but the process don't start up anymore.
a777524
to
0896860
Compare
…ket.Chat into chore/startup-performance
…ket.Chat into chore/startup-performance
…e/startup-performance
…ket.Chat into chore/startup-performance
…ket.Chat into chore/startup-performance
…ket.Chat into chore/startup-performance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ts
is not being set- there is change on the previous behavior I'm not sure is good or bad.. Previously we couldn't change setting's value by only changing it on
settings.add
, but we could change everything else (like if a setting is public or not), but with the new implementation this is not possible anymore. looks like once the setting is saved on DB, it doesn't apply anything we change onsettingsRegister.add
- there a few errors during startup I think we should get rid of before merging, like:
Invalid setting code SMS_Mobex_from_number: Setting SMS_Mobex_from_number is of type int but got string
…ket.Chat into chore/startup-performance
…ket.Chat into chore/startup-performance
…ket.Chat into chore/startup-performance
Proposed changes (including videos or screenshots)
The settings logic has been improved as a whole.
All the logic to get the data from the env var was confusing.
Setting default values was tricky to understand.
Every time the server booted, all settings were updated and callbacks were called 2x or more (horrible for environments with multiple instances and generating a turbulent startup).
Settings.get(......, callback);
was deprecated. We now have better methods for each case.Issue(s)
Steps to test or reproduce
Further comments