Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Fix user registration stuck #23254

Merged
merged 2 commits into from
Sep 21, 2021
Merged

Conversation

sampaiodiego
Copy link
Member

Proposed changes (including videos or screenshots)

Apparently process.stdout.write must return true.

Tests were not failing due to mail output being "discarded" when running test env

// Send emails to a "fake" stream instead of print them in console

Issue(s)

Steps to test or reproduce

Further comments

@sampaiodiego sampaiodiego requested a review from a team September 21, 2021 15:02
@tassoevan tassoevan self-requested a review September 21, 2021 15:40
@ggazzo ggazzo merged commit 3e9fdbe into develop Sep 21, 2021
@ggazzo ggazzo deleted the fix-user-registration-stuck branch September 21, 2021 15:49
gabriellsh added a commit that referenced this pull request Sep 22, 2021
…to feat/seats-cap-fixes

* 'feat/seats-cap' of github.com:RocketChat/Rocket.Chat:
  Chore: Re-enable session tests on local after removal of mongo-unit (#23263)
  [BREAK] Moved role-sync and advanced SAML settings to EE (#23107)
  Remove uneffective conditional
  Always create seats limit banners
  Move startup
  Change occurences of Livechat to omnichannel were applicable (#23199)
  Regression: Log Sections not respecting Log Level setting (#23230)
  [BREAK] Removed support of MongoDB 3.4; Deprecated MongoDB 3.6 and 4.0 (#22907)
  Regression: Fix user registration stuck (#23254)
  [FIX] Mark agents as unavailable when they logout (#23219)
  [FIX] Toolbox click not working on Safari(iOS) (#23244)
  [FIX] Omnichannel On hold chats being forwarded to offline agents (#23185)
  [BREAK] LDAP Refactoring (#23171)
  [IMPROVE] Canned response admin settings (#23190)
  Chore: Update Livechat widget to 1.9.4 (#23198)
  useEndpoint (#23209)
  [FIX] Wrong docs link on Omni-Webhook page (#23117)
@sampaiodiego sampaiodiego mentioned this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants