-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Remove compose from main repo #23426
Conversation
@sampaiodiego review please :) |
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
797faec
to
78ccad2
Compare
5dc025a
to
855a7f1
Compare
what if we just remove the docker-compose from here? it is already buried in |
Honestly, I don't have any problem with that 😂 this whole should-we-should-we-not started on a seperate github thread that brought the topic "people automate updating compose files right from repo". I always was against catering to such practice. Well, since we already changed the path with monorepo migration, I suppose that argument is moot now. |
exactly.. it is already missing from the root of the repo where it used to be.. so I think that gives us green light to just delete it. |
I'll update the pr tomorrow. Also need to redirect to the other pr (to the new compose location) before merging/closing this one. |
Should we leave the file there with a note inside? Or a docker-compose.md with a note inside? |
IMO updating our docs should be enough :) |
…e/split-useUserInfoActions * 'develop' of github.com:RocketChat/Rocket.Chat: (41 commits) Regression: Fix apps wrong typing (#25824) Chore: Remove compose from main repo (#23426) [FIX] `You and @Yourusername reacted with`title on reactions (#25733) [FIX] AgentsPage pagination (#25820) Chore: Move voip's Wrap-up and On-hold functionality to EE (Backend) (#25160) [FIX] Access issue on chat.getThreadsList (#25750) Chore: Remove snap files from Houston config (#25819) [FIX] Voip endpoint permissions (#25783) [FIX] allow only livechat-agents to be contact manager for any omnichannel contact (#25451) Chore: use params instead of URL building on livechat endpoints (#25810) Regression: fix apps path (#25809) [BREAK] Remove RDStation integration (#25774) Chore: RestApiClient as Package (#25469) [FIX] Wrong argument name preventing Omnichannel Chat Forward to User (#25723) [FIX] AccountBox checks for condition (#25708) Chore: Fix CI (#25797) [FIX] Fix prom-client new promise usage (#25781) [FIX] Discussion alphabetical ordering (#25788) Update .kodiak.toml Update .kodiak.toml ...
…homepage * 'develop' of github.com:RocketChat/Rocket.Chat: (21 commits) [FIX] Client-generated sort parameters in channel directory (#25768) Chore: Add tests for agents screens (#25637) Chore: Notification Preferences to TS (#25827) Chore: Convert MemoizedSetting, Setting, Section (#25572) Regression: Fix users.create call (#25834) Chore: Add auto label and improve Kodiak configuration (#25829) Regression: Fix apps wrong typing (#25824) Chore: Remove compose from main repo (#23426) [FIX] `You and @Yourusername reacted with`title on reactions (#25733) [FIX] AgentsPage pagination (#25820) Chore: Move voip's Wrap-up and On-hold functionality to EE (Backend) (#25160) [FIX] Access issue on chat.getThreadsList (#25750) Chore: Remove snap files from Houston config (#25819) [FIX] Voip endpoint permissions (#25783) [FIX] allow only livechat-agents to be contact manager for any omnichannel contact (#25451) Chore: use params instead of URL building on livechat endpoints (#25810) Regression: fix apps path (#25809) [BREAK] Remove RDStation integration (#25774) Chore: RestApiClient as Package (#25469) [FIX] Wrong argument name preventing Omnichannel Chat Forward to User (#25723) ...
Closes #23584
Closes #23416
Closes #23402
Closes #24636
Closes #24160
Closes #23479
Closes #23341