Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Delay start of email inbox #23521

Merged
merged 2 commits into from
Oct 21, 2021
Merged

[FIX] Delay start of email inbox #23521

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e548f5
delay start of email inbox
KevLehman Oct 20, 2021
b303b0e
use watchOnce
KevLehman Oct 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion server/features/EmailInbox/EmailInbox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,5 +81,7 @@ export async function configureEmailInboxes(): Promise<void> {
}

Meteor.startup(() => {
configureEmailInboxes();
Meteor.defer(() => {
configureEmailInboxes();
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the point doing this? what does this actually fix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the issue with this one is that the email inbox depends on a setting being set (Routing_algo). Since the inbox can receive emails before the setting is set (because the setting now runs on a meteor startup) this was aiming to delay the execution of that inbox configuration (there is a task to replace this with a setting watch or another kind of delay too)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed there's a watchOnce now for settings, I'll use it and change this to that 👀

});