Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Email notifications settings not being honored on new DMs #23574

Merged
merged 14 commits into from
Dec 20, 2021
Merged

[FIX] Email notifications settings not being honored on new DMs #23574

merged 14 commits into from
Dec 20, 2021

Conversation

ostjen
Copy link
Contributor

@ostjen ostjen commented Oct 27, 2021

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@ostjen ostjen requested a review from sampaiodiego October 28, 2021 14:00
sampaiodiego
sampaiodiego requested changes Nov 24, 2021
View reviewed changes
app/lib/server/functions/createDirectRoom.js Outdated Show resolved Hide resolved
app/lib/server/functions/createDirectRoom.js Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Dec 17, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

sampaiodiego
sampaiodiego requested changes Dec 17, 2021
View reviewed changes
Copy link
Member

@sampaiodiego sampaiodiego left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update is deprecated on latest driver, please use updateOne instead

app/lib/server/functions/createDirectRoom.js Outdated Show resolved Hide resolved
app/lib/server/functions/createDirectRoom.js Outdated Show resolved Hide resolved
sampaiodiego
sampaiodiego previously approved these changes Dec 17, 2021
View reviewed changes
@sampaiodiego sampaiodiego changed the title [FIX] Email notifications settings not being used on DMs [FIX] Email notifications settings not being honored on new DMs Dec 20, 2021
@sampaiodiego sampaiodiego merged commit 05951c1 into develop Dec 20, 2021
@sampaiodiego sampaiodiego deleted the email_notifications_fix branch December 20, 2021 13:26
@sampaiodiego sampaiodiego mentioned this pull request Dec 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ostjen @CLAassistant @sampaiodiego