Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] No hover effect for items in kebab menu. #23712

Merged
merged 3 commits into from
Dec 3, 2021
Merged

[FIX] No hover effect for items in kebab menu. #23712

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
894b1ec
added hover effect to message kebab menu
Aman-Maheshwari Nov 14, 2021
5b6cee2
fix stylelint errors
Aman-Maheshwari Nov 14, 2021
c15061c
fix: review
dougfabris Nov 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions app/theme/client/imports/components/popover.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,20 @@
font-weight: 600;
}

&__wrapper {
padding-left: 16px;

&:hover {
border-radius: 2px;
background-color: #f7f8fa;
}
}

&__list {
width: 125%;
margin-left: -16px;
}

&__item {
display: flex;

Expand Down
33 changes: 18 additions & 15 deletions app/ui-utils/client/lib/popover.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,21 +13,24 @@ <h3 class="rc-popover__title">{{group.title}}</h3>
<ul class="rc-popover__list">
{{#each item in group.items}}
{{# with item}}
<li data-qa="{{qa}}" class="rc-popover__item {{#if item.modifier}}rc-popover__item--{{item.modifier}}{{/if}}{{#if hasAction}} js-action{{/if}}" data-type={{item.type}} data-id={{item.id.toLowerCase}} data-href={{item.href}} data-sidenav={{item.sideNav}}>
{{#if item.icon}}
<span class="rc-popover__icon">
{{> icon block="rc-popover__icon-element" icon=item.icon }}
</span>
{{/if}}
{{#if item.name}}
<span class="rc-popover__item-text">{{item.name}}</span>
{{/if}}
{{#if item.select}}
<span class="rc-popover__input">
{{> selectDropdown title=item.selectTitle name=item.selectName options=item.selectOptions}}
</span>
{{/if}}
</li>
<div class="rc-popover__wrapper">
<li data-qa="{{qa}}" class="rc-popover__item {{#if item.modifier}}rc-popover__item--{{item.modifier}}{{/if}}{{#if hasAction}} js-action{{/if}}" data-type={{item.type}} data-id={{item.id.toLowerCase}} data-href={{item.href}} data-sidenav={{item.sideNav}}>
{{#if item.icon}}
<span class="rc-popover__icon">
{{> icon block="rc-popover__icon-element" icon=item.icon }}
</span>
{{/if}}
{{#if item.name}}
<span class="rc-popover__item-text">{{item.name}}</span>
{{/if}}
{{#if item.select}}
<span class="rc-popover__input">
{{> selectDropdown title=item.selectTitle name=item.selectName options=item.selectOptions}}
</span>
{{/if}}
</li>
</div>

{{/with}}
{{/each}}
</ul>
Expand Down