[FIX] multiple user assigned for a role #23741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekgonecrazy
previously approved these changes
Nov 18, 2021
|
Thankyou @geekgonecrazy 😃 |
|
|
…iple-user-add-userRole
…iple-user-add-userRole
dionisio-bot
bot
added
stat: ready to merge
dougfabris
approved these changes
Nov 8, 2022
bkrith
pushed a commit
to bkrith/Rocket.Chat
that referenced
this pull request
Nov 12, 2022
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat> Co-authored-by: juliajforesti <juliajforesti@gmail.com> Co-authored-by: Júlia Jaeger Foresti <60678893+juliajforesti@users.noreply.github.com> Co-authored-by: dougfabris <devfabris@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Fixes RocketChat#23740
MartinSchoeler
pushed a commit
that referenced
this pull request
Nov 28, 2022
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat> Co-authored-by: juliajforesti <juliajforesti@gmail.com> Co-authored-by: Júlia Jaeger Foresti <60678893+juliajforesti@users.noreply.github.com> Co-authored-by: dougfabris <devfabris@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Fixes #23740
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
changed UserAutoComplete to UserAutoCompleteMultiple to allow handling multiple users. Also the add button is disable when there is no user selected to be added.
Before
before_multiple_add_user.mp4
After
after_multiple_add_user.mp4
Issue(s)
Fixes #23740
Steps to test or reproduce
Mentioned in the issue
Further comments