Chore: Enable prefer-optional-chain ESLint rule for TypeScript files #23786
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
— Rich Skrenta
Mixing two problem domains in code is prone to errors. In this small example
we're (1) checking the nullity of
y
and (2) attributingy.z
tox
, where (2) is clearly the main problem we're solving with code. The optional chaining is a good technique to handle nullity as a mere implementation detail:Attributing
y.z
tox
is more easily readable than the nullity check ofy
.This PR aims to add
@typescript-eslint/prefer-optional-chain
rule to ESlint configuration at warning level.Issue(s)
Steps to test or reproduce
Further comments