Chore: Improvements on role syncing (ldap, oauth and saml) #23824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ethods that can add and remove user roles. - converted `addUserRoles` and `removeUserFromRoles` to typescript - validate number of user seats available before converting a guest into a full user through role syncing.
pierre-lehnen-rc
changed the title
|
This pull request introduces 5 alerts when merging a150d4a into 44127c7 - view on LGTM.com new alerts:
|
|
This pull request introduces 5 alerts when merging 50bb204 into a0ed0b1 - view on LGTM.com new alerts:
|
…-sync-reorganization
tassoevan
reviewed
Dec 13, 2021
tassoevan
previously approved these changes
Dec 13, 2021
|
|
sampaiodiego
requested changes
Dec 20, 2021
There was a problem hiding this comment.
I saw you have created "sync" variants of some old functions.. the way we did before was keeping the old function as they were but creating an "async" version of them instead (see hasPermission and hasPermissionAsync). it concerns me a little bit if we mix both "patterns".. should we stick to what we've been doing far? wdyt?
…et.Chat into role-sync-reorganization
I think at some point we should switch to having the Async be the default and the Sync be the exception, but it would be best to update the old functions when we do so. I can switch the names around for this one for now. |
yes, that's definitely the idea. the "sync" versions are around just to make our lives easier during the migration. but at any time that we found we don't need the "sync" version anymore we should get rid of them. meanwhile I think we should be consistent, so I'd ask you to make "sync" version the "official one", and create an "async" alternate version of it.. actually the code should be on the "async" version, but you got the point 😅 |
…he explicitly named one
…nc be the explicitly named one
sampaiodiego
previously approved these changes
Dec 29, 2021
sampaiodiego
approved these changes
Mar 3, 2022
Merged
ear-dev
added a commit
to WideChat/Rocket.Chat
that referenced
this pull request
Jun 30, 2022
* Regression: Fix double value on holdTime and empty msg on last message (#24630)
* Fix time fields and add wrap up
* fix lint
* Regression: Fix missing hold time and wrap up time missing
* On cancel wrapup close room
* Fix lint
* Fix wrong code
* Oh boy I need more sleep
* Cherrypick fix
* Bump version to 4.5.0-rc.3
* Regression: Queue counter aggregator for incoming/hanged calls (#24635)
* Regression: Extension List panel UI not aligned with designs (#24645)
* Regression: Server crashing if Voip credentials are invalid (#24646)
* Fix wrong tab name. (#24647)
* Regression: Error setting user avatars and mentioning rooms on Slack Import (#24585)
* Add setting to control avatar rotation
* Fix users' and rooms' mentions, fix setUserAvatar error on import
* Remove unrelated changes
* Fix missing username on imported messages
* Reverted some changes
* Fixed mentions
* Removed duplicated code
* Fix #23808
Co-authored-by: Pierre Lehnen <pierre.lehnen@rocket.chat>
* Bump version to 4.5.0-rc.4
* Regression: Prevent button from losing state when rerendering (#24648)
Authored by @amolghode1981
* Refresh server connection when MI server settings change (#24649)
* Bump version to 4.5.0-rc.5
* Chore: Update Apps-Engine (#24651)
* Update Apps-Engine
* Update Apps-Engine
* Bump version to 4.5.0-rc.6
* Bump version to 4.5.0
* Bump version to 4.6.0-develop
* [IMPROVE] Updated links in readme (#24028)
* updated links in readme
* changed link to point to playlist
* added email link
* README: add missing verb
Co-authored-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
* [FIX] Typo in wrap-up term (#24661)
* Bump url-parse from 1.5.7 to 1.5.10 (#24640)
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](https://github.com/unshiftio/url-parse/compare/1.5.7...1.5.10)
---
updated-dependencies:
- dependency-name: url-parse
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump @types/ws from 8.2.3 to 8.5.2 in /ee/server/services (#24666)
Bumps [@types/ws](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ws) from 8.2.3 to 8.5.2.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ws)
---
updated-dependencies:
- dependency-name: "@types/ws"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump ts-node from 10.5.0 to 10.6.0 in /ee/server/services (#24667)
Bumps [ts-node](https://github.com/TypeStrong/ts-node) from 10.5.0 to 10.6.0.
- [Release notes](https://github.com/TypeStrong/ts-node/releases)
- [Commits](https://github.com/TypeStrong/ts-node/compare/v10.5.0...v10.6.0)
---
updated-dependencies:
- dependency-name: ts-node
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Chore(deps-dev): Bump @types/mock-require from 2.0.0 to 2.0.1 (#24574)
Bumps [@types/mock-require](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/mock-require) from 2.0.0 to 2.0.1.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/mock-require)
---
updated-dependencies:
- dependency-name: "@types/mock-require"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump actions/checkout from 2 to 3 (#24668)
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v2...v3)
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [FIX] Duplicated 'name' log key (#24590)
* i18n: Language update from LingoHub 🤖 on 2022-02-28Z (#24644)
* Language update from LingoHub 🤖
Project Name: Rocket.Chat
Project Link: https://translate.lingohub.com/rocketchat/dashboard/rocket-dot-chat
User: Robot LingoHub
Easy language translations with LingoHub 🚀
* Apply suggestions from code review
* Update packages/rocketchat-i18n/i18n/de.i18n.json
Co-authored-by: Robot LingoHub <robot@lingohub.com>
Co-authored-by: Diego Sampaio <chinello@gmail.com>
* Bump actions/setup-node from 2 to 3 (#24642)
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 2 to 3.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](https://github.com/actions/setup-node/compare/v2...v3)
---
updated-dependencies:
- dependency-name: actions/setup-node
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fix messages being imported without sender's username (#24674)
* Bump pino-pretty from 7.5.1 to 7.5.2 in /ee/server/services (#24689)
Bumps [pino-pretty](https://github.com/pinojs/pino-pretty) from 7.5.1 to 7.5.2.
- [Release notes](https://github.com/pinojs/pino-pretty/releases)
- [Commits](https://github.com/pinojs/pino-pretty/compare/v7.5.1...v7.5.2)
---
updated-dependencies:
- dependency-name: pino-pretty
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Chore: Improvements on role syncing (ldap, oauth and saml) (#23824)
* - created a single `syncUserRoles` function to be used by all login methods that can add and remove user roles.
- converted `addUserRoles` and `removeUserFromRoles` to typescript
- validate number of user seats available before converting a guest into a full user through role syncing.
* typo
* missed async call
* Code review
* Removed promise.await
* sync call
* Renamed async and sync version of addUserRoles to make the async be the explicitly named one
* Renamed async and sync version of removeUserFromRoles to make the async be the explicitly named one
* prettier
* fixed type
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
* Fix room's message count not being incremented on import (#24696)
* Bump pino-pretty from 7.5.2 to 7.5.3 in /ee/server/services (#24698)
Bumps [pino-pretty](https://github.com/pinojs/pino-pretty) from 7.5.2 to 7.5.3.
- [Release notes](https://github.com/pinojs/pino-pretty/releases)
- [Commits](https://github.com/pinojs/pino-pretty/compare/v7.5.2...v7.5.3)
---
updated-dependencies:
- dependency-name: pino-pretty
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Description : Fixing LGTM error. Instead of assignment, extra |=| was typed. (#24657)
* [FIX] Nextcloud OAuth for incomplete token URL (#24476)
* Bump ts-node from 10.6.0 to 10.7.0 in /ee/server/services (#24716)
Bumps [ts-node](https://github.com/TypeStrong/ts-node) from 10.6.0 to 10.7.0.
- [Release notes](https://github.com/TypeStrong/ts-node/releases)
- [Commits](https://github.com/TypeStrong/ts-node/compare/v10.6.0...v10.7.0)
---
updated-dependencies:
- dependency-name: ts-node
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [FIX] API Error preventing adding an email to users without one (like bot/app users) (#24709)
* [FIX] Date Message Export Filter Fix (#24542)
* Fix Date Filter in Export Messages
* Comment fix
* small fixes
* [FIX] Components for user search (#24677)
* Replace AutoComplete with MultiSelectFiltered on CreateTeamModal/UsersInput
* regression fuselage packages
* Handle loading state
* fix UserAutoCompleteMultiple to handle id as a value
* manage dataLabel filtering
* Set default prop value
* Add default valueIsId in UserAutoCompleteMultiple
* remove log
* Add missing `useMemo` dependency
* Use function state dispatch to avoid triggering a new effect
* Fix prettier formatting
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
* Chore: Improve logger to allow log of `unknown` values (#24726)
* [FIX] VoIP Enable/Disable setting on CallContext/CallProvider Notifications (#24607)
* i18n: Language update from LingoHub 🤖 on 2022-03-07Z (#24717)
* Language update from LingoHub 🤖
Project Name: Rocket.Chat
Project Link: https://translate.lingohub.com/rocketchat/dashboard/rocket-dot-chat
User: Robot LingoHub
Easy language translations with LingoHub 🚀
* Update packages/rocketchat-i18n/i18n/es.i18n.json
* Update packages/rocketchat-i18n/i18n/es.i18n.json
* Apply suggestions from code review
Co-authored-by: Robot LingoHub <robot@lingohub.com>
Co-authored-by: Diego Sampaio <chinello@gmail.com>
* [FIX][ENTERPRISE] Presence micro service logic (#24724)
* [FIX] DDP streamer errors (#24710)
* [FIX] Show only available agents on extension association modal (#24680)
Co-authored-by: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat>
* [FIX][ENTERPRISE] DDP streamer not sending data to all clients (#24738)
* [IMPROVE][ENTERPRISE] Don't start presence monitor when running micro services (#24739)
* [FIX] Typo and placeholder on wrap up call modal (#24737)
* Chore: Fix Cypress tests (#24544)
Co-authored-by: dougfabris <devfabris@gmail.com>
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
* Stop sending system messages when adding or removing a group from a team (#24743)
* [FIX] Reload roomslist after successful deletion of a room from admin panel. (#23795)
* fix- delete rooms from admin refresh roomlist and close contextual menu
* added success toast message
* fix-lint
* fix-lint: missing dependency
* Handle failing `eraseRoom` call
* Handle list changes on save/archive too
* Handle teams as a special case
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
* Chore: resolve grammatical errors in Code of Conduct (#24759)
* Chore: fix grammatical errors in FEATURES.md (#24771)
* Fixed Grammatical Error
* Chore: Fixed grammatical errors in Features
* Fix sender if close room message has no id (#24683)
* Chore: Update Livechat (#24754)
* [FIX] Apple login script being loaded even when Apple Login is disabled. (#24760)
* Regression: Improve Sidenav open/close handling and fixed codeql configs and E2E tests (#24756)
* [FIX] Typo in wrap-up term (#24661)
* [FIX] Duplicated 'name' log key (#24590)
* Fix messages being imported without sender's username (#24674)
* Fix room's message count not being incremented on import (#24696)
* Description : Fixing LGTM error. Instead of assignment, extra |=| was typed. (#24657)
* [FIX] Components for user search (#24677)
* Replace AutoComplete with MultiSelectFiltered on CreateTeamModal/UsersInput
* regression fuselage packages
* Handle loading state
* fix UserAutoCompleteMultiple to handle id as a value
* manage dataLabel filtering
* Set default prop value
* Add default valueIsId in UserAutoCompleteMultiple
* remove log
* Add missing `useMemo` dependency
* Use function state dispatch to avoid triggering a new effect
* Fix prettier formatting
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
* [FIX] VoIP Enable/Disable setting on CallContext/CallProvider Notifications (#24607)
* [FIX] Show only available agents on extension association modal (#24680)
Co-authored-by: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat>
* [FIX] Typo and placeholder on wrap up call modal (#24737)
* Stop sending system messages when adding or removing a group from a team (#24743)
* [FIX] Reload roomslist after successful deletion of a room from admin panel. (#23795)
* fix- delete rooms from admin refresh roomlist and close contextual menu
* added success toast message
* fix-lint
* fix-lint: missing dependency
* Handle failing `eraseRoom` call
* Handle list changes on save/archive too
* Handle teams as a special case
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
* Fix sender if close room message has no id (#24683)
* Chore: Update Livechat (#24754)
* [FIX] Apple login script being loaded even when Apple Login is disabled. (#24760)
* Bump version to 4.5.1
* Chore: Micro services fixes and cleanup (#24753)
* [IMPROVE] UX - VoIP Call Component (#24748)
* [IMPROVE] Voip Extensions disabled state (#24750)
* [FIX] Opening a new DM from user card (#24623)
* Change `useRoomIcon` signature
* Fix `IRoom[t]` and `ISubscription[t]`
* Ensure `IRoom['uids']` is not mandatory
* Fix some typings
* [FIX] Show call icon only when user has extension associated (#24752)
* Bump jschardet from 1.6.0 to 3.0.0 (#23121)
Bumps [jschardet](https://github.com/aadsm/jschardet) from 1.6.0 to 3.0.0.
- [Release notes](https://github.com/aadsm/jschardet/releases)
- [Commits](https://github.com/aadsm/jschardet/compare/v1.6.0...v3.0.0)
---
updated-dependencies:
- dependency-name: jschardet
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump pino from 7.8.0 to 7.8.1 in /ee/server/services (#24783)
Bumps [pino](https://github.com/pinojs/pino) from 7.8.0 to 7.8.1.
- [Release notes](https://github.com/pinojs/pino/releases)
- [Commits](https://github.com/pinojs/pino/compare/v7.8.0...v7.8.1)
---
updated-dependencies:
- dependency-name: pino
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [FIX][ENTERPRISE] Auto reload feature of ddp-streamer micro service (#24793)
* [FIX] Broken multiple OAuth integrations (#24705)
* Chore: Convert server functions from javascript to typescript (#24384)
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
* [FIX] VoipExtensionsPage component call (#24792)
* Regression: Register services right away (#24800)
* [FIX] Prevent call button toggle when user is on call (#24758)
* Chore: added Server Instances endpoint types (#24507)
* [FIX] "livechat/webrtc.call" endpoint not working (#24804)
* [FIX] Critical: Incorrect visitor getting assigned to a chat from apps (#24805)
* [FIX] Prune Message issue (#24424)
Co-authored-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
* [FIX] Handle Other Formats inside Upload Avatar (#24226)
Co-authored-by: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com>
Co-authored-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
* Chore: added settings endpoint types (#24506)
Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com>
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
* Chore: converted more hooks to typescript (#24628)
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
* [FIX] `PaginatedSelectFiltered` not handling changes (#24732)
* Bump Fuselage packages to `@next` versions
* Bump Fuselage packages to `@latest` versions
* Chore: Get Settings Statistics (#24397)
* Fix: logic and alias of Canned Response
* Add File Upload Enable
* Regression: Fix ParentRoomWithEndpointData in loop (#24809)
* [FIX] "Match error" when converting a team to a channel (#24629)
* Fix teams.listRoomsOfUser error when the canUserDelete param is sent
* Chore: Skip local services changes when shutting down duplicated services (#24810)
* Bump prometheus-gc-stats from 0.6.2 to 0.6.3 (#24803)
Bumps [prometheus-gc-stats](https://github.com/SimenB/node-prometheus-gc-stats) from 0.6.2 to 0.6.3.
- [Release notes](https://github.com/SimenB/node-prometheus-gc-stats/releases)
- [Commits](https://github.com/SimenB/node-prometheus-gc-stats/compare/v0.6.2...v0.6.3)
---
updated-dependencies:
- dependency-name: prometheus-gc-stats
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump is-svg from 4.3.1 to 4.3.2 (#24801)
Bumps [is-svg](https://github.com/sindresorhus/is-svg) from 4.3.1 to 4.3.2.
- [Release notes](https://github.com/sindresorhus/is-svg/releases)
- [Commits](https://github.com/sindresorhus/is-svg/compare/v4.3.1...v4.3.2)
---
updated-dependencies:
- dependency-name: is-svg
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Chore: APIClass types (#24747)
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
* [FIX] Revert AutoComplete (#24812)
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
* [IMPROVE] Voip Extensions disabled state (#24750)
* [FIX] Opening a new DM from user card (#24623)
* Change `useRoomIcon` signature
* Fix `IRoom[t]` and `ISubscription[t]`
* Ensure `IRoom['uids']` is not mandatory
* Fix some typings
* [FIX] Broken multiple OAuth integrations (#24705)
* [FIX] VoipExtensionsPage component call (#24792)
* [FIX] "livechat/webrtc.call" endpoint not working (#24804)
* [FIX] Critical: Incorrect visitor getting assigned to a chat from apps (#24805)
* [FIX] `PaginatedSelectFiltered` not handling changes (#24732)
* Bump Fuselage packages to `@next` versions
* Bump Fuselage packages to `@latest` versions
* Regression: Fix ParentRoomWithEndpointData in loop (#24809)
* [FIX] Revert AutoComplete (#24812)
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
* Bump version to 4.5.2
* [FIX] German translation for Monitore (#24785)
* Chore: Add E2E tests for livechat/room.close (#24729)
Co-authored-by: Kevin Aleman <kevin.aleman@rocket.chat>
* Chore: Add E2E tests for livechat/visitor (#24764)
Co-authored-by: Kevin Aleman <kevin.aleman@rocket.chat>
* Bump @types/ws from 8.5.2 to 8.5.3 in /ee/server/services (#24820)
Bumps [@types/ws](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ws) from 8.5.2 to 8.5.3.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/ws)
---
updated-dependencies:
- dependency-name: "@types/ws"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump body-parser from 1.19.0 to 1.19.2 (#24821)
Bumps [body-parser](https://github.com/expressjs/body-parser) from 1.19.0 to 1.19.2.
- [Release notes](https://github.com/expressjs/body-parser/releases)
- [Changelog](https://github.com/expressjs/body-parser/blob/master/HISTORY.md)
- [Commits](https://github.com/expressjs/body-parser/compare/1.19.0...1.19.2)
---
updated-dependencies:
- dependency-name: body-parser
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump @types/nodemailer from 6.4.2 to 6.4.4 (#24822)
Bumps [@types/nodemailer](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/nodemailer) from 6.4.2 to 6.4.4.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/nodemailer)
---
updated-dependencies:
- dependency-name: "@types/nodemailer"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump @types/clipboard from 2.0.1 to 2.0.7 (#24832)
Bumps [@types/clipboard](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/clipboard) from 2.0.1 to 2.0.7.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/clipboard)
---
updated-dependencies:
- dependency-name: "@types/clipboard"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump @types/mailparser from 3.0.2 to 3.4.0 (#24833)
Bumps [@types/mailparser](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/mailparser) from 3.0.2 to 3.4.0.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/mailparser)
---
updated-dependencies:
- dependency-name: "@types/mailparser"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* i18n: Language update from LingoHub 🤖 on 2022-03-14Z (#24823)
* Language update from LingoHub 🤖
Project Name: Rocket.Chat
Project Link: https://translate.lingohub.com/rocketchat/dashboard/rocket-dot-chat
User: Robot LingoHub
Easy language translations with LingoHub 🚀
* Update packages/rocketchat-i18n/i18n/ca.i18n.json
Co-authored-by: Robot LingoHub <robot@lingohub.com>
Co-authored-by: Diego Sampaio <chinello@gmail.com>
* [FIX] Show only enabled departments on forward (#24829)
* [FIX] Wrong param usage on queue summary call (#24799)
* [FIX] VoIP button gets disabled whenever user status changes (#24789)
* Clickup task : https://app.clickup.com/t/25jwe53
Description : Whenever the user state is changed (Explicitly or automatically by the virtue of user's inactivity)
Voip component gets reloaded. Also during the reload of the page, the Voip component gets initialised multiple times, causing
multiple websockets opened to asterisk.
This happens because of the following facts:
1. The useEffect of useVoipClient, which creates the Voip component had user in its dependency list.
2. Whenever any user property changes, it would cause the useEffect to trigger and execute the entire initialisation of
voip component.
3. When state change happens, it triggers update on all the components. So OmnichannelCallToggleReady gets re-rendered, also useVoipClient causes reinitialisation (user state change).
4. Now, when the useEffect of OmnichannelCallToggleReady gets executed, voipClient.getRegistrarState(); value is not |registered| because the state change has caused reinitialisation
of voip component, which is not registered.
5. So again, the phone button value gets reset, the agent becomes unavailable.
Fix:
Even though the user state may change, user identity does not change. SIP client reinitialisation should happen only when userId changes.
So the fix is not to add the entire userObject in the dependency list of the useEffect of useVoipClient hook. Instead
1. Create a state userId.
2. Add another useEffect watching the user. Whenever user becomes available or any user change happens, update the userId
3. The useEffect which does the voip client initialisation, should have the userId in the dependency list.
When this is done, the Voip initialisation will happen only when userId changes.
* Clickup task : https://app.clickup.com/t/25jwe53
Description : Realised that we have useUserId hook. As we have this hook, removed the useEffect which
fetches the userId from user. Also removed the state. Instead added a constant userId.
* Clickup Tasks: https://app.clickup.com/t/25jwe53 and https://app.clickup.com/t/22xdyn5
Description :
Though this workspace was fix the first issue, it was realised that there are few other issues
which are dependent on this(Not all may have a clickup task associated).
This commit also fixes following :
1. Voip button does not get disabled when the user state changes. This happens because the user gets updated whenever the state change happens, this causes useVoipClient to reload
this reload causes the reinitialsation of voipUser which initialises the connection again.
2. PR https://github.com/RocketChat/Rocket.Chat/pull/24752 : This PR fixes the icon display only when the extension associated with the user. This is also fixed as this was broken due to fix for #1. (THis was using user object, and we are now not using the user object directly in the useEffect for voipClient initialisation.
3. This fix broke the fact that whenever user gets associated with the agent, voip button gets active. But because we removed the use of user, This was broken too. This got fixed by the virtue of fixing #2, i.e using extension as a state.
4. Even though the association is deleted, agent was still receiving the call. This was because the SIP user was never unregistered and cleared when the association gets deleted. Fixed this issue by calling voipClient.stop() method. This would take care of unregistering if the UA is registered and then closing the webSocket.
* [IMPROVE] Standarize queue behavior for managers and agents when subscribing (#24837)
* Standarize queue behavior for managers and agents when subscribing to department/public queues
* Fix import
* Remove task from comment
* [FIX] Match SidebarFooter component with design (#24838)
* Regression: Role Sync not always working (#24850)
* [FIX] Broken build caused by PRs modifying same file differently(#24863)
Co-authored-by: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat>
* [FIX] Disable voip button when call is in progress (#24864)
* Bump pino-pretty from 7.5.3 to 7.5.4 in /ee/server/services (#24870)
Bumps [pino-pretty](https://github.com/pinojs/pino-pretty) from 7.5.3 to 7.5.4.
- [Release notes](https://github.com/pinojs/pino-pretty/releases)
- [Commits](https://github.com/pinojs/pino-pretty/compare/v7.5.3...v7.5.4)
---
updated-dependencies:
- dependency-name: pino-pretty
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump pino from 7.8.1 to 7.9.1 in /ee/server/services (#24869)
Bumps [pino](https://github.com/pinojs/pino) from 7.8.1 to 7.9.1.
- [Release notes](https://github.com/pinojs/pino/releases)
- [Commits](https://github.com/pinojs/pino/compare/v7.8.1...v7.9.1)
---
updated-dependencies:
- dependency-name: pino
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [FIX] auto-join team channels not honoring user preferences (#24779)
* fixed subscriptions w/o notifications pref
* added tests
* typo
* removed unwantend method call
* moved some tests to sync methods
* finally fixed tests
* Chore: Fix MongoDB versions on release notes (#24877)
* [FIX] Missing dependency on useEffect at CallProvider (#24882)
* [IMPROVE] New omnichannel statistics and async statistics processing. (#24749)
* re-pushing changes
* fixing code review suggestions and changed requirements
* Useless code removed
* fixing CI complaints
* Missing await
* Language update from LingoHub 🤖 (#24895)
Project Name: Rocket.Chat
Project Link: https://translate.lingohub.com/rocketchat/dashboard/rocket-dot-chat
User: Robot LingoHub
Easy language translations with LingoHub 🚀
Co-authored-by: Robot LingoHub <robot@lingohub.com>
* [FIX] Apple OAuth (#24879)
* [FIX] Ignore customClass on messages (#24845)
* [FIX] Wrong business hour behavior (#24896)
* [FIX] Custom script not being fired (#24901)
* [IMPROVE] UX - VoIP Call Component (#24748)
* [FIX] Show call icon only when user has extension associated (#24752)
* [FIX] VoIP button gets disabled whenever user status changes (#24789)
* Clickup task : https://app.clickup.com/t/25jwe53
Description : Whenever the user state is changed (Explicitly or automatically by the virtue of user's inactivity)
Voip component gets reloaded. Also during the reload of the page, the Voip component gets initialised multiple times, causing
multiple websockets opened to asterisk.
This happens because of the following facts:
1. The useEffect of useVoipClient, which creates the Voip component had user in its dependency list.
2. Whenever any user property changes, it would cause the useEffect to trigger and execute the entire initialisation of
voip component.
3. When state change happens, it triggers update on all the components. So OmnichannelCallToggleReady gets re-rendered, also useVoipClient causes reinitialisation (user state change).
4. Now, when the useEffect of OmnichannelCallToggleReady gets executed, voipClient.getRegistrarState(); value is not |registered| because the state change has caused reinitialisation
of voip component, which is not registered.
5. So again, the phone button value gets reset, the agent becomes unavailable.
Fix:
Even though the user state may change, user identity does not change. SIP client reinitialisation should happen only when userId changes.
So the fix is not to add the entire userObject in the dependency list of the useEffect of useVoipClient hook. Instead
1. Create a state userId.
2. Add another useEffect watching the user. Whenever user becomes available or any user change happens, update the userId
3. The useEffect which does the voip client initialisation, should have the userId in the dependency list.
When this is done, the Voip initialisation will happen only when userId changes.
* Clickup task : https://app.clickup.com/t/25jwe53
Description : Realised that we have useUserId hook. As we have this hook, removed the useEffect which
fetches the userId from user. Also removed the state. Instead added a constant userId.
* Clickup Tasks: https://app.clickup.com/t/25jwe53 and https://app.clickup.com/t/22xdyn5
Description :
Though this workspace was fix the first issue, it was realised that there are few other issues
which are dependent on this(Not all may have a clickup task associated).
This commit also fixes following :
1. Voip button does not get disabled when the user state changes. This happens because the user gets updated whenever the state change happens, this causes useVoipClient to reload
this reload causes the reinitialsation of voipUser which initialises the connection again.
2. PR https://github.com/RocketChat/Rocket.Chat/pull/24752 : This PR fixes the icon display only when the extension associated with the user. This is also fixed as this was broken due to fix for #1. (THis was using user object, and we are now not using the user object directly in the useEffect for voipClient initialisation.
3. This fix broke the fact that whenever user gets associated with the agent, voip button gets active. But because we removed the use of user, This was broken too. This got fixed by the virtue of fixing #2, i.e using extension as a state.
4. Even though the association is deleted, agent was still receiving the call. This was because the SIP user was never unregistered and cleared when the association gets deleted. Fixed this issue by calling voipClient.stop() method. This would take care of unregistering if the UA is registered and then closing the webSocket.
* [FIX] Wrong param usage on queue summary call (#24799)
* [FIX] Show only enabled departments on forward (#24829)
* [IMPROVE] Standarize queue behavior for managers and agents when subscribing (#24837)
* Standarize queue behavior for managers and agents when subscribing to department/public queues
* Fix import
* Remove task from comment
* [FIX] Match SidebarFooter component with design (#24838)
* [FIX] Broken build caused by PRs modifying same file differently(#24863)
Co-authored-by: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat>
* [FIX] Disable voip button when call is in progress (#24864)
* Chore: Fix MongoDB versions on release notes (#24877)
* [FIX] Custom script not being fired (#24901)
* Bump version to 4.5.3
* [FIX] Push privacy config to not show username not being respected (#24606)
* [FIX][ENTERPRISE] Notifications not being sent by ddp-streamer (#24831)
* [FIX] DDP Rate Limiter Translation key (#24898)
* Chore: Remove old scripts (#24911)
* [IMPROVE] Adding new statistics related to voip and omnichannel (#24887)
Co-authored-by: Kevin Aleman <kaleman960@gmail.com>
* [NEW] Telemetry Events (#24781)
* stats events api and engagement dashboard
* Engagement Dashboard stats
* Message Auditing
* Jitsi Stats
* otr stats
* improvements
* rewrite telemetry events
* improved types and queries
* telemetry events generics
* otr stats update
* auth required in telemetry endpoint
* Update app/otr/client/rocketchat.otr.room.js
Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com>
* fixed api calls
* removed console.log()
* lint
* fixed more broken API calls
* fixed types
* incrementValueByID + moved OTR telemtry call from end() to acknoledge()
* IStats update
Co-authored-by: Leonardo Ostjen Couto <leonardoostjen@gmail.com>
Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com>
* [FIX] Several issues related to custom roles (#24052)
* [FIX] `roles.delete` not properly checking if subscription based roles are being used
* Improved typings
* Added error message in development if a role scope is passed to a method that expects a scope value
* Fix prettier rules
* Replace role name by id in findUsersInRole
* Fix Users In Role page
* Fix role not available error
* Fix Users in Role screen for users' custom roles
* Check if role exists before adding to user
* Fix Remove user from role
* Fix roles _id field
* Partial commit of changes
* some changes
* merge fixes
* Replaces some names with ids
* parseCSV util
* ts
* Changes from yesterday
* api
* Removed more roleNames
* typo
* roles.getUsersInRole
* findUsersInRole
* fixed import path
* removeUserFromRoles
* Removed comments
* removed comment
* migration
* Imports
* types
* createOrUpdateProtectedRole
* Removed DetailedError
* tests
* await server fresh install
* Update server/lib/roles/updateRole.ts
Co-authored-by: Matheus Barbosa Silva <36537004+matheusbsilva137@users.noreply.github.com>
* MeteorErrors
* Display role name in UserInfo when description is not available
* Migrate roleNames
* syntax
* syntax
* Review fixes
Co-authored-by: Matheus Barbosa Silva <36537004+matheusbsilva137@users.noreply.github.com>
Co-authored-by: matheusbsilva137 <matheus_barbosa137@hotmail.com>
* Bump version to 4.6.0-rc.0
* [FIX] External search providers not working (#24860)
* [FIX] Duplicated "jump to message" button on starred messages (#24867)
* Regression: Fix account service login expiration (#24920)
* [NEW] Engagement Statistics (#24777)
* White label stats
* lint fix
* Invites
* Models Methods
* Teams stats and 2fa stats
* Users Created Stats
* Import Fix
* Import Fix 2
* team fix
* moved to statistics.ts
Co-authored-by: Leonardo Ostjen Couto <leonardoostjen@gmail.com>
* Regression: Call doesn't stop ringing after agent unregistration (#24908)
* [FIX] Force name to string (#24930)
* Force name and email to string
If its ever anything but a string. Like an array for example It borks the user list because of the aggregations done to bring in users
* Removed force to string for email
Downstream user creation logic handles this so its safe to let go as is
* Log number of values received per attribute
* Allow multiple emails
Co-authored-by: Pierre Lehnen <pierre.lehnen@rocket.chat>
* [FIX] LDAP avatars being rotated according to metadata even if the setting to rotate uploads is off (#24320)
Co-authored-by: Pierre Lehnen <pierre.lehnen@rocket.chat>
* [FIX] Force name to string (#24930)
* Force name and email to string
If its ever anything but a string. Like an array for example It borks the user list because of the aggregations done to bring in users
* Removed force to string for email
Downstream user creation logic handles this so its safe to let go as is
* Log number of values received per attribute
* Allow multiple emails
Co-authored-by: Pierre Lehnen <pierre.lehnen@rocket.chat>
* Bump version to 4.5.4
* Bump version to 4.6.0-rc.1
* Regression: Fix unexpected errors breaking ddp-streamer (#24948)
* [FIX] Register with Secret URL (#24921)
* render Login Form on correct hash
* remove log
* Language update from LingoHub 🤖 (#24971)
Project Name: Rocket.Chat
Project Link: https://translate.lingohub.com/rocketchat/dashboard/rocket-dot-chat
User: Robot LingoHub
Easy language translations with LingoHub 🚀
Co-authored-by: Robot LingoHub <robot@lingohub.com>
* Chore: add some missing REST definitions (#24925)
* Fix room archived/unarchived system messages (#24897)
* Revert "[NEW] Engagement Statistics (#24777)" (#24989)
This reverts commit f79e7eb5bbe13a4f577c648c254110fcf579f322.
* Chore: Update Livechat (#24990)
* Chore: Storybook mocking and examples improved (#24969)
* Upgrade Storybook
* Replace `ts-loader` with `babel-loader`
* Rearrange some stories
* Rearrange some stories
* Move `NotAuthorizedPage`
* Rearrange some stories
* Rearrange some stories
* Rearrange some stories
* Rearrange some stories
* Rearrange some stories
* Squashed commit of the following:
commit f0cda61edf0c6d9341c87096ebaa1e014eb8747a
Author: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat>
Date: Fri Mar 25 15:45:59 2022 -0300
fix review
commit 4113ffb9336d661bd31711155738ca6f1bc4c3e1
Author: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat>
Date: Thu Mar 24 17:34:48 2022 -0300
fix
commit 82e14b6c187b78b2ca73e6fbcbeb524443b6a7ad
Author: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat>
Date: Thu Mar 24 17:18:57 2022 -0300
fix
* Rearrange some stories
* Rearrange some stories
* Improve `ServerProviderMock` with parameters
* Expand story mocking capabilities
* Move mocks
* Fix lint issues
* [FIX] room message not load when is a new message (#24955)
* fix: if not find room on subscription try on chatroom
* refactor: remove aditional request and aadd rid
* refactor: remove unsed async
* fields -> projection
* fix link to new users on spotlight
Co-authored-by: Pierre Lehnen <pierre.lehnen@rocket.chat>
* Bump version to 4.6.0-rc.2
* [FIX] High CPU usage caused by CallProvider (#24994)
* fix infinite loop
* fix
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
* Bump version to 4.6.0-rc.3
* Chore: Update Livechat (#24990)
* [FIX] room message not load when is a new message (#24955)
* fix: if not find room on subscription try on chatroom
* refactor: remove aditional request and aadd rid
* refactor: remove unsed async
* fields -> projection
* fix link to new users on spotlight
Co-authored-by: Pierre Lehnen <pierre.lehnen@rocket.chat>
* [FIX] High CPU usage caused by CallProvider (#24994)
* fix infinite loop
* fix
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
* Bump version to 4.5.5
* Clickup task : https://app.clickup.com/t/29gujj8 (#24980)
Description :
In ACDQueue.ts,
When there is no queue available on asterisk, onQueueSummary never gets executed. It directly calls onQueueSummaryComplete
Because result.queueSummary never got initialised, result is undefined.
This causes getQueueDetails fails as it assumes that there will be a valid queue summary.
To fix this, set result.queueSummary to empty array if it does not already exist in onQueueSummaryComplete of ACDQueue.ts
* [NEW] Upgrade Tab (#24835)
* Add Upgrade tab on sidebar
* chore: add new icons
* [NEW] UpgradeTab Page Error (#24851)
* new: upgradeTab error
* remove route
Co-authored-by: gabriellsh <gabriel.henriques@rocket.chat>
* [NEW] UpgradeTab Iframe (#24881)
* WIP
* chore: code org
* Iframe navigation
* WIP tabtype endpoint
* chore: revert endpoint name
* new: connect UpgradePageError to iframe page
* WIP tabtype 2
* Update links to redirect
* Wip had trial before
* update cloud.getUpgradeTabParams endpoint
* Add tests
* Remove logs
Co-authored-by: gabriellsh <gabriel.henriques@rocket.chat>
* fix: missing hasRole function
* fix: upgradeTab routing
* chore: missing import
* fix: setting value
* fix: update setting value on sync
* fix: missing isLoading in route
* Small screen, language and review
* Avoid unnecessary query
* chore: review
* Retype `useUpgradeTabParams`
* Rename `UpgradeTabVariants` as `UpgradeTabVariant`
* Remove placeholder data; fix route redirection
* Replace history instead of pushing it
* fix: gold license & trialEnd date
* wip
* Rework `useUpgradeTabParams`
* fix: valid licenses
* fix: query loading
* fix: license type
Co-authored-by: dougfabris <devfabris@gmail.com>
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
Co-authored-by: Pierre Lehnen <pierre.lehnen@rocket.chat>
* Regression: Custom roles displaying ID instead of name on some admin screens (#24999)
* Regression: Custom roles displaying ID instead of name on admin screens
* fix: missing NewRolePage role name validation
* Update client/views/admin/users/AddUser.js
Co-authored-by: Douglas Fabris <devfabris@gmail.com>
* filter
* prettier
Co-authored-by: dougfabris <devfabris@gmail.com>
* Chore: Bump Fuselage packages (#25015)
* chore: bump version
* Bump to 0.31.9
* Workaround misuse of `Box`'s `withRichContent` prop
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
* Regression: Add createdOTR index (#25017)
* Bump version to 4.6.0-rc.4
* Bump @rocket.chat/string-helpers in /ee/server/services (#25018)
Bumps [@rocket.chat/string-helpers](https://github.com/RocketChat/Rocket.Chat.Fuselage/tree/HEAD/packages/string-helpers) from 0.31.4 to 0.31.9.
- [Release notes](https://github.com/RocketChat/Rocket.Chat.Fuselage/releases)
- [Changelog](https://github.com/RocketChat/Rocket.Chat.Fuselage/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/RocketChat/Rocket.Chat.Fuselage/commits/v0.31.9/packages/string-helpers)
---
updated-dependencies:
- dependency-name: "@rocket.chat/string-helpers"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump @rocket.chat/message-parser in /ee/server/services (#25019)
Bumps [@rocket.chat/message-parser](https://github.com/RocketChat/Rocket.Chat.Fuselage/tree/HEAD/packages/message-parser) from 0.31.4 to 0.31.9.
- [Release notes](https://github.com/RocketChat/Rocket.Chat.Fuselage/releases)
- [Changelog](https://github.com/RocketChat/Rocket.Chat.Fuselage/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/RocketChat/Rocket.Chat.Fuselage/commits/v0.31.9/packages/message-parser)
---
updated-dependencies:
- dependency-name: "@rocket.chat/message-parser"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump @rocket.chat/ui-kit from 0.31.4 to 0.31.9 in /ee/server/services (#25020)
Bumps [@rocket.chat/ui-kit](https://github.com/RocketChat/Rocket.Chat.Fuselage) from 0.31.4 to 0.31.9.
- [Release notes](https://github.com/RocketChat/Rocket.Chat.Fuselage/releases)
- [Changelog](https://github.com/RocketChat/Rocket.Chat.Fuselage/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/RocketChat/Rocket.Chat.Fuselage/compare/v0.31.4...v0.31.9)
---
updated-dependencies:
- dependency-name: "@rocket.chat/ui-kit"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump @rocket.chat/emitter from 0.31.4 to 0.31.9 in /ee/server/services (#25021)
Bumps [@rocket.chat/emitter](https://github.com/RocketChat/Rocket.Chat.Fuselage) from 0.31.4 to 0.31.9.
- [Release notes](https://github.com/RocketChat/Rocket.Chat.Fuselage/releases)
- [Changelog](https://github.com/RocketChat/Rocket.Chat.Fuselage/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/RocketChat/Rocket.Chat.Fuselage/compare/v0.31.4...v0.31.9)
---
updated-dependencies:
- dependency-name: "@rocket.chat/emitter"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump version to 4.6.0-rc.5
* Bump version to 4.6.0
* [FIX] UserAutoComplete not rendering UserAvatar correctly (#25055)
* [FIX] Upgrade Tab showing for a split second (#25050)
* [FIX] NPS never finishing sending results (#25067)
* [FIX] FormData uploads not working (#25069)
* fix useEndpointUpload hook
* chore: remove log
Co-authored-by: dougfabris <devfabris@gmail.com>
* [FIX] Invitation links don't redirect to the registration form (#25082)
* [FIX] Proxy settings being ignored (#25022)
Co-authored-by: Diego Sampaio <chinello@gmail.com>
* Bump version to 4.6.1
* [FIX] Deactivating user not working if user is the only room owner (#24933)
* [FIX] Database indexes not being created (#25101)
* Bump version to 4.6.2
* [FIX] Desktop notification on multi-instance environments (#25220)
* Bump version to 4.6.3
* Merge branch 'develop_pwa' of https://github.com/WideChat/Rocket.Chat into develop_pwa-catchup-596881e
* Add package.lock
* Fix import for filters page
* Fix viasat bot role creation
* Fix lint error
* Update package-lock
* Remove duplicate translation key
* Fix merge problems
* Add package lock
* Remove cypress UI test workflow
* Disable E2E UI tests for github workflow
* Add catchup to PR title checker
* Add push to acc-ecr workflow
* Add pushm to message check
* Fix missing test method
* Add missed catchup changes
* Add telephoneNumber as optional field
Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat>
Co-authored-by: Pierre Lehnen <pierre.lehnen@rocket.chat>
Co-authored-by: amolghode1981 <86001342+amolghode1981@users.noreply.github.com>
Co-authored-by: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com>
Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com>
Co-authored-by: Matheus Barbosa Silva <36537004+matheusbsilva137@users.noreply.github.com>
Co-authored-by: Kevin Aleman <kevin.aleman@rocket.chat>
Co-authored-by: Douglas Gubert <douglas.gubert@gmail.com>
Co-authored-by: Diego Sampaio <chinello@gmail.com>
Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com>
Co-authored-by: P Aswini Kumar <aswini123p@gmail.com>
Co-authored-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: lingohub[bot] <69908207+lingohub[bot]@users.noreply.github.com>
Co-authored-by: Robot LingoHub <robot@lingohub.com>
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
Co-authored-by: eduardofcabrera <64327259+eduardofcabrera@users.noreply.github.com>
Co-authored-by: Júlia Jaeger Foresti <60678893+juliajforesti@users.noreply.github.com>
Co-authored-by: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat>
Co-authored-by: Rodrigo Nascimento <rodrigoknascimento@gmail.com>
Co-authored-by: dougfabris <devfabris@gmail.com>
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
Co-authored-by: Aman-Maheshwari <50165440+Aman-Maheshwari@users.noreply.github.com>
Co-authored-by: Aadish Jain <83128425+aadishJ01@users.noreply.github.com>
Co-authored-by: Cuong Huu Nguyen <cuonghuunguyen98@gmail.com>
Co-authored-by: Felipe <84182706+felipe-rod123@users.noreply.github.com>
Co-authored-by: Nishant Patel <53515714+nishant23122000@users.noreply.github.com>
Co-authored-by: Fábio Albuquerque <albuquerquefabio@icloud.com>
Co-authored-by: JMoVS <git@justinscholz.de>
Co-authored-by: Pedro Muramatsu <pedromuramatsuc@gmail.com>
Co-authored-by: Kevin Aleman <kaleman960@gmail.com>
Co-authored-by: Leonardo Ostjen Couto <leonardoostjen@gmail.com>
Co-authored-by: Cauê Felchar <11652381+cauefcr@users.noreply.github.com>
Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com>
Co-authored-by: matheusbsilva137 <matheus_barbosa137@hotmail.com>
Co-authored-by: Allan Ribeiro <allan_paz_ribeiro@hotmail.com>
Co-authored-by: Thomas Kurz <thomas.kurz@redlink.at>
Co-authored-by: Himanshu Malviya <76220055+Himanshu664@users.noreply.github.com>
Co-authored-by: Aaron Ogle <geekgonecrazy@users.noreply.github.com>
Co-authored-by: Allan RIbeiro <35040806+AllanPazRibeiro@users.noreply.github.com>
Co-authored-by: Yash Rajpal <58601732+yash-rajpal@users.noreply.github.com>
Co-authored-by: Gerzon Z <gerzonzcanario@gmail.com>
Co-authored-by: Filipe Marins <filipe.marins@rocket.chat>
Co-authored-by: Sidharth Mohanty <sidmohanty11@gmail.com>
Co-authored-by: Aditya Bhardwaj <aditya.1998bhardwaj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addUserRolesandremoveUserFromRolesto typescript