Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Add missing .png to clipboard uploaded file name #23833

Merged
merged 5 commits into from
Dec 17, 2021
Merged

[FIX] Add missing .png to clipboard uploaded file name #23833

merged 5 commits into from
Dec 17, 2021

Conversation

dougfabris
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Closes #20165

Steps to test or reproduce

Further comments

@dougfabris dougfabris mentioned this pull request Dec 1, 2021
Closed
@dougfabris @yash-rajpal
fix: add missing .png extension
091b3b7 
Co-authored-by: yash-rajpal <58601732+yash-rajpal@users.noreply.github.com>
@dougfabris dougfabris force-pushed the fix/missing-png-extension branch from 6fed020 to 091b3b7 Compare December 1, 2021 13:42
@dougfabris dougfabris requested a review from a team December 1, 2021 14:20
@tassoevan
Copy link
Contributor

tassoevan commented Dec 1, 2021 •
edited
Loading

There are several image/* formats that are not portable across browsers. Maybe it's the initial opportunity to improve our format detection. Consider the tables here: https://developer.mozilla.org/en-US/docs/Web/Media/Formats/Image_types

@dougfabris dougfabris requested a review from tassoevan December 10, 2021 14:52
tassoevan
tassoevan requested changes Dec 13, 2021
View reviewed changes
app/ui-message/client/messageBox/messageBox.js Outdated Show resolved Hide resolved
lib/getImageExtensionFromMime.ts Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Dec 17, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dougfabris dougfabris merged commit dce8a14 into develop Dec 17, 2021
@dougfabris dougfabris deleted the fix/missing-png-extension branch December 17, 2021 19:04
@dougfabris dougfabris added this to the 4.3.0 milestone Dec 17, 2021
@sampaiodiego sampaiodiego mentioned this pull request Dec 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriellsh gabriellsh gabriellsh left review comments

@tassoevan tassoevan tassoevan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

[BUG] Add .png extension to pictures pasted from clipboard
4 participants
@dougfabris @tassoevan @CLAassistant @gabriellsh