Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: added last login to users.list #23846

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Chore: added last login to users.list #23846

merged 1 commit into from
Dec 20, 2021

Conversation

ostjen
Copy link
Contributor

@ostjen ostjen commented Dec 2, 2021

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@ostjen ostjen requested a review from sampaiodiego December 2, 2021 17:58
sampaiodiego
sampaiodiego requested changes Dec 2, 2021
View reviewed changes
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of adding lastLogin to the results for every call, we should instead respect defaultLimitedUserFieldsToExclude for users without the required permission

@ostjen ostjen requested a review from sampaiodiego December 8, 2021 17:18
@CLAassistant
Copy link

CLAassistant commented Dec 17, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sampaiodiego sampaiodiego merged commit 04ad659 into develop Dec 20, 2021
@sampaiodiego sampaiodiego deleted the users_list_last_login branch December 20, 2021 13:27
@sampaiodiego sampaiodiego mentioned this pull request Dec 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ostjen @CLAassistant @sampaiodiego