Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Replace SortListItem and CreateListItem with ListItem #24007

Merged
merged 19 commits into from
Dec 22, 2021

Conversation

juliajforesti
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Replace SortListItem and CreateListItem for ListItem using fuselage's Option components.

@juliajforesti juliajforesti requested a review from ggazzo December 21, 2021 22:42
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have added 1 .js files, please convert to ts(x).
client/components/Sidebar/ListItem.js

@github-actions github-actions bot dismissed their stale review December 21, 2021 22:59

js files removed

@ggazzo ggazzo merged commit eba77e1 into develop Dec 22, 2021
@ggazzo ggazzo deleted the improve/Dropdown branch December 22, 2021 02:38
@sampaiodiego sampaiodiego mentioned this pull request Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants