Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Team system messages feedback #24209

Merged
merged 17 commits into from
Feb 18, 2022
Merged

Conversation

ostjen
Copy link
Contributor

@ostjen ostjen commented Jan 18, 2022

Proposed changes (including videos or screenshots)

  • Delete some keys that aren't being used (eg: User_left_female).
  • Add new Teams' system messages:
    • added-user-to-team: added @\user to this Team;
    • removed-user-from-team: removed @\user from this Team;
    • user-converted-to-team: converted #\room to a Team;
    • user-converted-to-channel: converted #\room to a Channel;
    • user-removed-room-from-team: removed @\user from this Team;
    • user-deleted-room-from-team: deleted #\room from this Team;
    • user-added-room-to-team: deleted #\room to this Team;
  • Add the corresponding options to hide each new system message and the missing ujt and ult hide options.

Issue(s)

Closes #22420

Steps to test or reproduce

Further comments

@ostjen ostjen requested a review from dougfabris January 18, 2022 19:05
tassoevan
tassoevan previously approved these changes Jan 21, 2022
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing some sys messages! I'm working on that!

@dougfabris dougfabris changed the title Chore: Improved some system message texts [IMPROVE] Team system messages feedback Feb 15, 2022
@dougfabris dougfabris added this to the 4.5.0 milestone Feb 15, 2022
@dougfabris dougfabris force-pushed the sys_messages_new_texts branch from 7152950 to 0f1ff46 Compare February 15, 2022 23:58
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matheusbsilva137 mgs id to check in cronProcessDownload:

  • user-removed-room-from-team
  • user-deleted-room-from-team
  • user-added-room-to-team
  • ujt
  • ult

dougfabris
dougfabris previously approved these changes Feb 17, 2022
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks a lot @matheusbsilva137

@dougfabris dougfabris force-pushed the sys_messages_new_texts branch from e529632 to e63ab55 Compare February 17, 2022 23:58
@dougfabris dougfabris merged commit bfaa1db into develop Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants