[FIX] Add ?close to OAuth callback url #24381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierre-lehnen-rc
approved these changes
Feb 2, 2022
pierre-lehnen-rc
pushed a commit
that referenced
this pull request
Feb 7, 2022
Merged
This was referenced Feb 7, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
On Meteor 2.3 release, they've removed a deprecated behavior of adding
?closeto callback URL of OAuth clients. This PR is just adding the same logic back.We need to think of a migration path for our costumers as well.
Issue(s)
Closes #24355
Steps to test or reproduce
Further comments