Regression: Prevent connect to asterisk when VoIP is disabled

app/voip/server/startup.ts

@@ -0,0 +1,6 @@
+import { settings } from '../../settings/server';
+import { Voip } from '../../../server/sdk';
+
+settings.watch('VoIP_Enabled', (value: boolean) => {
+	return value ? Voip.init() : Voip.stop();
+});

server/importPackages.ts

@@ -109,3 +109,4 @@ import '../app/reactions/server';
 import '../app/livechat/server';
 import '../app/custom/server';
 import '../app/authentication/server';
+import '../app/voip/server/startup';

server/sdk/types/IVoipService.ts

@@ -16,4 +16,6 @@ export interface IVoipService {
 	checkManagementConnection(host: string, port: string, userName: string, password: string): Promise<IManagementServerConnectionStatus>;
 	checkCallserverConnection(websocketUrl: string, protocol?: string): Promise<IManagementServerConnectionStatus>;
 	cachedQueueDetails(): () => Promise<{ name: string; members: string[] }[]>;
+	init(): Promise<void>;
+	stop(): Promise<void>;
 }

server/services/voip/connector/asterisk/CommandHandler.ts

@@ -150,5 +150,8 @@ export class CommandHandler {
 
 	stop(): void {
 		this.continuousMonitor.cleanMonitor();
+		for (const connection of this.connections.values()) {
+			connection.closeConnection();
+		}
 	}
 }

server/services/voip/service.ts

@@ -31,11 +31,19 @@ export class VoipService extends ServiceClassInternal implements IVoipService {
 
 		this.logger = new Logger('VoIPService');
 		this.commandHandler = new CommandHandler(db);
-		try {
-			Promise.await(this.commandHandler.initConnection(CommandType.AMI));
-		} catch (error) {
-			this.logger.error({ msg: `Error while initialising the connector. error = ${error}` });
-		}
+		this.init();
+	}
+
+	async init(): Promise<void> {
+		this.logger.info('Starting VoIP service');
+		await this.commandHandler.initConnection(CommandType.AMI);
+		this.logger.info('VoIP service started');
+	}
+
+	async stop(): Promise<void> {
+		this.logger.info('Stopping VoIP service');
+		await this.commandHandler.stop();
+		this.logger.info('VoIP service stopped');
 	}
 
 	getServerConfigData(type: ServerType): IVoipCallServerConfig | IVoipManagementServerConfig {

tests/end-to-end/api/02-channels.js

@@ -281,6 +281,7 @@ describe('[Channels]', function () {
 	});
 
 	describe('[/channels.files]', () => {
+		before(() => updateSetting('VoIP_Enabled', true));
 		const createVoipRoom = async () => {
 			const testUser = await createUser({ roles: ['user', 'livechat-agent'] });
 			const visitor = await createVisitor();