-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Create direct message from search #24797
Conversation
Hey Deb! |
Closes #23041 |
Try develop branch. |
Ah crap. Thanks for confirming :P |
@ankar84 can you double check please? I just heard that this is not working in 4.5.2 :/ |
I will do it today, because it was all perfect in develop branch... |
Hm thanks. I'm outside so can't test it rn. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this will solve anything.
Looking at your changes, the only thing that really changes is adding the ability to use ids instead of usernames.
I looked in the code, and I didn't find any place that uses ID. So I don't know how that would fix anything.
What I think is that this is an intermittent case, which happens due to latency/delay issues. And in your case, without this problem, it fooled you, but if the problem ever existed, it's still there.
anyway thanks for trying, as soon as i have some time i'll post the resolution here
The search result was generating a link with the user id instead of the username, but that was fixed on #24955, so this change will no longer be necessary. |
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
Probably not the best solution but it works :/