Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Create direct message from search #24797

Closed
wants to merge 2 commits into from
Closed

[FIX] Create direct message from search #24797

wants to merge 2 commits into from

Conversation

debdutdeb
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Probably not the best solution but it works :/

@ankar84
Copy link

ankar84 commented Mar 11, 2022

Hey Deb!
What that PR should fix?
Creating DM was fixed in #24623
Is your case still not fixed?

@debdutdeb
Copy link
Member Author

Screenshot_2022-03-11-11-49-36-157_com android chrome
No looks like it hasn't.

@debdutdeb
Copy link
Member Author

Closes #23041

@ankar84
Copy link

ankar84 commented Mar 11, 2022

No looks like it hasn't.

Try develop branch.
I tested - all works perfect.
Fix not in 4.5.1

@debdutdeb
Copy link
Member Author

Ah crap. Thanks for confirming :P

@debdutdeb debdutdeb closed this Mar 11, 2022
@debdutdeb
Copy link
Member Author

@ankar84 can you double check please? I just heard that this is not working in 4.5.2 :/

@ankar84
Copy link

ankar84 commented Mar 14, 2022

@ankar84 can you double check please? I just heard that this is not working in 4.5.2 :/

I will do it today, because it was all perfect in develop branch...

@debdutdeb
Copy link
Member Author

Hm thanks. I'm outside so can't test it rn.

@debdutdeb debdutdeb reopened this Mar 14, 2022
@tassoevan tassoevan requested a review from a team March 14, 2022 16:58
@fojtasd
Copy link

fojtasd commented Mar 15, 2022

We have the same issue + another kind of bug -> some of the users have LDAP username instead of nickname or name in the bar. If I use this username, then I have this result.

image

Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will solve anything.
Looking at your changes, the only thing that really changes is adding the ability to use ids instead of usernames.
I looked in the code, and I didn't find any place that uses ID. So I don't know how that would fix anything.

What I think is that this is an intermittent case, which happens due to latency/delay issues. And in your case, without this problem, it fooled you, but if the problem ever existed, it's still there.

anyway thanks for trying, as soon as i have some time i'll post the resolution here

@ggazzo ggazzo added the wontfix label Mar 23, 2022
@pierre-lehnen-rc
Copy link
Contributor

The search result was generating a link with the user id instead of the username, but that was fixed on #24955, so this change will no longer be necessary.

@tassoevan tassoevan deleted the create-dm branch September 28, 2022 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants