Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Convert Mailer to TS #25121

Merged
merged 3 commits into from
Apr 8, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/meteor/client/contexts/ServerContext/methods.ts
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ export type ServerMethods = {
'livechat:saveTrigger': (...args: any[]) => any;
'livechat:saveUnit': (...args: any[]) => any;
'livechat:webhookTest': (...args: any[]) => any;
'Mailer.sendMail': (...args: any[]) => any;
'Mailer.sendMail': (from: string, subject: string, body: string, dryrun: boolean, query: string) => any;
'muteUserInRoom': (...args: any[]) => any;
'personalAccessTokens:generateToken': (...args: any[]) => any;
'personalAccessTokens:regenerateToken': (...args: any[]) => any;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,17 +1,22 @@
import { TextInput, TextAreaInput, Field, FieldGroup, CheckBox, Button, Icon, ButtonGroup } from '@rocket.chat/fuselage';
import React, { useState, useCallback } from 'react';
import React, { useState, useCallback, SyntheticEvent } from 'react';

import { validateEmail } from '../../../../lib/emailValidator';
import { isJSON } from '../../../../lib/utils/isJSON';
import Page from '../../../components/Page';
import { useTranslation } from '../../../contexts/TranslationContext';
import { sendMailObject } from './MailerRoute';

export function Mailer({ sendMail = () => {} }) {
type MailerProps = {
sendMail: ({ fromEmail, subject, emailBody, dryRun, query }: sendMailObject) => void;
};

export function Mailer({ sendMail }: MailerProps) {
const t = useTranslation();

const [fromEmail, setFromEmail] = useState({ value: '' });
const [fromEmail, setFromEmail] = useState<{ value: string; error?: string }>({ value: '' });
const [dryRun, setDryRun] = useState(false);
const [query, setQuery] = useState({ value: '' });
const [query, setQuery] = useState<{ value: string; error?: string }>({ value: '' });
const [subject, setSubject] = useState('');
const [emailBody, setEmailBody] = useState('');

Expand Down Expand Up @@ -40,10 +45,10 @@ export function Mailer({ sendMail = () => {} }) {
placeholder={t('Type_your_email')}
value={fromEmail.value}
error={fromEmail.error}
onChange={(e) => {
onChange={(e: SyntheticEvent<HTMLInputElement>) => {
setFromEmail({
value: e.currentTarget.value,
error: !validateEmail(e.currentTarget.value) ? t('Invalid_Email') : undefined,
error: !validateEmail(e.currentTarget.value) ? t('Invalid_email') : undefined,
});
}}
/>
Expand All @@ -63,7 +68,7 @@ export function Mailer({ sendMail = () => {} }) {
id='query'
value={query.value}
error={query.error}
onChange={(e) => {
onChange={(e: SyntheticEvent<HTMLInputElement>) => {
setQuery({
value: e.currentTarget.value,
error: e.currentTarget.value && !isJSON(e.currentTarget.value) ? t('Invalid_JSON') : undefined,
Expand All @@ -78,9 +83,8 @@ export function Mailer({ sendMail = () => {} }) {
<Field.Row>
<TextInput
id='subject'
value={subject.value}
error={subject.error}
onChange={(e) => {
value={subject}
onChange={(e: SyntheticEvent<HTMLInputElement>) => {
setSubject(e.currentTarget.value);
}}
/>
Expand All @@ -89,7 +93,12 @@ export function Mailer({ sendMail = () => {} }) {
<Field>
<Field.Label>{t('Email_body')}</Field.Label>
<Field.Row>
<TextAreaInput id='emailBody' rows={10} value={emailBody} onChange={(e) => setEmailBody(e.currentTarget.value)} />
<TextAreaInput
id='emailBody'
rows={10}
value={emailBody}
onChange={(e: SyntheticEvent<HTMLInputElement>) => setEmailBody(e.currentTarget.value)}
/>
</Field.Row>
<Field.Hint dangerouslySetInnerHTML={{ __html: t('Mailer_body_tags') }} />
</Field>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,17 @@ import { useTranslation } from '../../../contexts/TranslationContext';
import NotAuthorizedPage from '../../notAuthorized/NotAuthorizedPage';
import { Mailer } from './Mailer';

const useSendMail = () => {
export type sendMailObject = {
fromEmail: { value: string; error?: string };
subject: string;
emailBody: string;
dryRun: boolean;
query: { value: string; error?: string };
};

type useSendMailType = () => ({ fromEmail, subject, emailBody, dryRun, query }: sendMailObject) => void;

const useSendMail: useSendMailType = () => {
const meteorSendMail = useMethod('Mailer.sendMail');
const t = useTranslation();
const dispatchToastMessage = useToastMessageDispatch();
Expand All @@ -20,7 +30,7 @@ const useSendMail = () => {
});
return;
}
if (fromEmail.error || fromEmail.length < 1) {
if (fromEmail.error || fromEmail.value.length < 1) {
dispatchToastMessage({
type: 'error',
message: t('error-invalid-from-address'),
Expand Down
3 changes: 2 additions & 1 deletion apps/meteor/packages/rocketchat-i18n/i18n/en.i18n.json
Original file line number Diff line number Diff line change
Expand Up @@ -2354,6 +2354,7 @@
"Invalid_setting_s": "Invalid setting: %s",
"Invalid_two_factor_code": "Invalid two factor code",
"Invalid_username": "The username entered is invalid",
"Invalid_JSON": "Invalid JSON",
"invisible": "invisible",
"Invisible": "Invisible",
"Invitation": "Invitation",
Expand Down Expand Up @@ -4994,4 +4995,4 @@
"onboarding.form.standaloneServerForm.servicesUnavailable": "Some of the services will be unavailable or will require manual setup",
"onboarding.form.standaloneServerForm.publishOwnApp": "In order to send push notitications you need to compile and publish your own app to Google Play and App Store",
"onboarding.form.standaloneServerForm.manuallyIntegrate": "Need to manually integrate with external services"
}
}