Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Upgrade tab loader in incorrect position #25398

Merged
merged 5 commits into from
May 23, 2022
Merged

[FIX] Upgrade tab loader in incorrect position #25398

merged 5 commits into from
May 23, 2022

Conversation

guijun13
Copy link
Contributor

@guijun13 guijun13 commented May 4, 2022 •
edited
Loading

Proposed changes (including videos or screenshots)

  • Add invisible prop to iframe when loading state is active.

Issue(s)

Steps to test or reproduce

  • Administration > Upgrade tab page
  • The loader should be in the center of the page and it should disappear when content appears.

Further comments

@guijun13 guijun13 marked this pull request as draft May 4, 2022 18:27
@guijun13 guijun13 marked this pull request as ready for review May 4, 2022 21:10
@guijun13 guijun13 requested a review from gabriellsh May 4, 2022 21:11
@guijun13 guijun13 requested review from tassoevan and removed request for gabriellsh May 13, 2022 17:57
@guijun13 guijun13 requested a review from a team as a code owner May 16, 2022 15:51
@guijun13 guijun13 merged commit 47c5498 into develop May 23, 2022
@guijun13 guijun13 deleted the fix/upgrade-tab-loader branch May 23, 2022 18:50
@casalsgh casalsgh added this to the 4.8.0 milestone May 23, 2022
ggazzo pushed a commit that referenced this pull request May 24, 2022
@guijun13 @tassoevan @ggazzo
[FIX] Upgrade tab loader in incorrect position (#25398)
4cb19dd 
* feat: position correctly the loader with CSS

* fix: hide iframe when loading

* Remove extra curly brackets

Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
ggazzo pushed a commit that referenced this pull request May 30, 2022
@guijun13 @tassoevan @ggazzo
[FIX] Upgrade tab loader in incorrect position (#25398)
96ee679 
* feat: position correctly the loader with CSS

* fix: hide iframe when loading

* Remove extra curly brackets

Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
@d-gubert d-gubert mentioned this pull request May 31, 2022
Merged
@murtaza98 murtaza98 mentioned this pull request Jul 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tassoevan tassoevan tassoevan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@guijun13 @tassoevan @casalsgh