Chore: Convert slashCommands to typescript #25592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teAll Chore: Convert to typescript the slash commands invite all files
Chore: Convert to typescript the kick slash commands files
…to ts/slash-commands
… ts/slash-commands
…o ts/slash-commands
…nto ts/slash-commands
…to ts/slash-commands
ggazzo
approved these changes
May 23, 2022
gabriellsh
added a commit
that referenced
this pull request
May 23, 2022
…adMessagePreview * 'develop' of github.com:RocketChat/Rocket.Chat: (29 commits) [FIX] Pinned Message display cutting off information (#25535) Chore: Dependencies upgrade (#25290) Chore: bump fuselage (#25605) [NEW] Federation (Alpha Stabilization) (#25457) Chore: Convert to typescript some functions from app/lib/server/functions (#24519) [NEW] Add option to show mentions badge when show counter is disabled (#25329) [FIX] Fixing Network connectivity issues with SIP client. (#25391) [FIX] Ordered and unordered list styles, Line breaks. (#25494) Chore: Convert slashCommands to typescript (#25592) [NEW] Get user's preferred language via apps (#25514) [NEW] Star message, report and delete message events (#25383) [NEW] Add new events after user login, logout and change his status (#25234) [NEW] Add new app events for pin, react and follow message (#25337) Chore: Convert AutoTranslate (#25591) Chore: Migrate retention-policy to ts (#25582) Chore: Convert to typescript the slash commands help files (#24307) Chore: Convert Create Channel (#25589) Chore: Convert additionalForms (#25586) Chore: Rewrite autotranslate to ts (#25425) [NEW] Add user events for apps (#25165) ...
ggazzo
added a commit
that referenced
this pull request
May 24, 2022
Co-authored-by: Eduardo Cabrera <eduardo.cabrera@rocket.chat> Co-authored-by: Leonardo Ostjen Couto <leonardoostjen@gmail.com> Co-authored-by: eduardofcabrera <64327259+eduardofcabrera@users.noreply.github.com> Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR converts the slashCommands object to typescript and defines all related types.
Issue(s)
Steps to test or reproduce
Further comments
There are inconsistencies between the core types and the Apps engines types. Fixing it will require changing things on the Apps Engine side.