-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Permission view-all-teams
is not checked in the teams.info
endpoint
#25841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Invalid PR Title
stat: needs QA
and removed
Invalid PR Title
labels
Jun 13, 2022
LucianoPierdona
changed the title
Fix/view teams info permission
[FIX] view teams info permission
Jun 13, 2022
KevLehman
reviewed
Jun 13, 2022
LucianoPierdona
changed the title
[FIX] view teams info permission
[FIX][BREAK] view teams info permission
Jun 13, 2022
LucianoPierdona
changed the title
[FIX][BREAK] view teams info permission
[BREAK] view teams info permission
Jun 13, 2022
matheusbsilva137
previously approved these changes
Jun 24, 2022
matheusbsilva137
previously approved these changes
Jun 27, 2022
ggazzo
changed the title
[BREAK] view teams info permission
[FIX] View teams info permission
Jun 27, 2022
ggazzo
previously approved these changes
Jun 29, 2022
matheusbsilva137
requested changes
Aug 12, 2022
matheusbsilva137
requested changes
Aug 15, 2022
matheusbsilva137
requested changes
Aug 16, 2022
Co-authored-by: Matheus Barbosa Silva <36537004+matheusbsilva137@users.noreply.github.com>
matheusbsilva137
changed the title
[FIX] View teams info permission
[FIX] Permission Aug 16, 2022
view-all-teams
is not checked in the teams.info
endpoint
matheusbsilva137
approved these changes
Aug 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We just need a review from the chat-engine team for the new tests.
ggazzo
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: needs QA
labels
Aug 17, 2022
ggazzo
approved these changes
Aug 17, 2022
csuadev
pushed a commit
that referenced
this pull request
Aug 26, 2022
…endpoint (#25841) Co-authored-by: Matheus Barbosa Silva <36537004+matheusbsilva137@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Previously any authenticated user was able to access the
teams.info
endpoint, this PR updates this so only users with theview-all-teams
permission or team members can access it.Issue(s)
Steps to test or reproduce
User 1
User 2
curl
Expected result
view-all-teams
permission, the response must beunauthorized
;view-all-teams
permission, the response must be succesful;view-all-teams
permission.Further comments