Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAK] remove unused endpoints and restify others #25889

Merged
merged 21 commits into from
Jun 29, 2022

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Jun 15, 2022

Proposed changes (including videos or screenshots)

Here's a list of changes:

  • API /v1/livechat/office-hours Deleted
  • Meteor method: livechat:getInitialData deleted
  • Meteor method: livechat:startFileUploadRoom deleted
  • API /v1/livechat/tags.list renamed to /v1/livechat/tags
  • API /v1/livechat/tags.getOne renamed to /v1/livechat/tags/:tagId
  • API /v1/livechat/priorities.list renamed to /v1/livechat/priorities
  • API /v1/livechat/priorities.getOne renamed to /v1/livechat/priorities/:priorityId
  • API /v1/livechat/business-hours.list renamed to /v1/livechat/business-hours
  • API livechat/units.list renamed to livechat/units
  • API /v1/livechat/units.getOne renamed to /v1/livechat/units/:unitId
  • API livechat/unitMonitors.list renamed to livechat/units/:unitId/monitors
  • API livechat/departments.available-by-unit/:unitId renamed to livechat/units/:unitId/departments/available
  • API livechat/departments.by-unit/:id renamed to livechat/units/:unitId/departments
  • API livechat/monitors.list renamed to livechat/monitors

Issue(s)

Steps to test or reproduce

Further comments

@KevLehman KevLehman requested review from a team as code owners June 15, 2022 17:03
@KevLehman KevLehman requested a review from a team June 15, 2022 17:04
@KevLehman KevLehman added this to the 5.0.0 milestone Jun 15, 2022
murtaza98
murtaza98 previously approved these changes Jun 24, 2022
Copy link
Contributor

@murtaza98 murtaza98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

murtaza98
murtaza98 previously approved these changes Jun 27, 2022
murtaza98
murtaza98 previously approved these changes Jun 28, 2022
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jun 28, 2022
@kodiakhq kodiakhq bot merged commit a7f3789 into develop Jun 29, 2022
@kodiakhq kodiakhq bot deleted the break/remove-endpoints branch June 29, 2022 03:18
gabriellsh added a commit that referenced this pull request Jun 29, 2022
…turbo

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [NEW] Community Edition Watermark (#25844)
  [BREAK] remove unused endpoints and restify others (#25889)
  Chore: add underscore to ddp-streamer
  [IMPROVE] VoIP admin page cleanup: remove unused settings (#25993)
  Regression: Fix micro services (#26054)
  Regression: Fix threads list (#26052)
  [NEW] VoIP Input/Output Device Selection (#25966)
  Chore: Account/Profile to TS (#25929)
gabriellsh added a commit that referenced this pull request Jun 29, 2022
…/clientPackage

* 'develop' of github.com:RocketChat/Rocket.Chat: (80 commits)
  [NEW] Community Edition Watermark (#25844)
  [BREAK] remove unused endpoints and restify others (#25889)
  Chore: add underscore to ddp-streamer
  [IMPROVE] VoIP admin page cleanup: remove unused settings (#25993)
  Regression: Fix micro services (#26054)
  Regression: Fix threads list (#26052)
  [NEW] VoIP Input/Output Device Selection (#25966)
  Chore: Account/Profile to TS (#25929)
  Chore: Add missing Swedish livechat translations (#26048)
  [IMPROVE] Expand the feature set of the new message rendering (#25970)
  Chore: Bump fuselage and update icon (#26036)
  [NEW][APPS] Allowing apps to register authenticated routes (#25937)
  [NEW] Enable outbound calling for EE (#25843) (#25960)
  Chore: Introduce new index to query active livechat conversations for cloud scaling (#26047)
  [FIX] Importer fails to download files from URLs with query string params (#25934)
  [IMPROVE] Moved call hold/unhold to EE (#26007)
  [NEW] Engagement Metrics - Phase 2 (#25505)
  Chore: Convert usePreventDefault, useQueryOptions, useShortcutOpenMenu (#26035)
  [FIX] Importer files are unnecessarily transferred over the network. (#25919)
  Chore: test turbo params (#26038)
  ...
@murtaza98 murtaza98 mentioned this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants