[NEW] Create releases tab in the marketplace app info page #25965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…app info page Refactored the ApiDisplay to be inside of the AppDetails component, changed the name of the AppDetailsPageContent component since now it is a tab content, changed the name of the AppLogsPage for the same reason and also changed the name of the AppSecurity page component.
Created new components AppReleases and ReleaseItem and mocked some data to make it faithful to figma. Will be integrating it with the back-end next.
Implemented the first necessary steps to integrating the AppReleases component with the back-end by passing down the appId and creating a local hook to deal with fetching the versions. Unfortunately the GET request necessary to fetch that data does not exist yet. Will be implementing it after the request creation.
Created a apps/:appId/versions endpoint to fetch all versions of a given app so that I finish the AppReleases component. Co-authored-by: Matheus Carmo <matheus.carmo@rocket.chat>
Fetched the app versions list, mapped it into a releases array, and implemented the AccordionItems list of releases.
Refactored the timestamp of the last updated field of the AppDetailsHeader component for maintainability reasons and to make it more straightforward.
Implemented the useTimeAgo hook to format the created date of the release entries. Also removed the Time normalizer sufix from the date strings to make it respect the current selected locale.
Refactored the i18n english dictionary to solve the thousands of unwanted modifications on remote.
Implemented a parsing method, using dangerouslySetInnerHTML, to parse the html of the release item rendered markdown. Also refactored some of the loading and error logic for the AppReleases to better benefit from the async state nature of useEndpointData.
…pp-info-releases-tab
graywolf336
suggested changes
Jun 27, 2022
graywolf336
reviewed
Jun 27, 2022
Fixed a problem where the whole details page component would refresh upon clicking on a tab if you came from the marketplace list of apps.
This was a little bug because of a misuse of the router functions, should be solved after this last commit. |
|
Awesome, can you update the demo gif? |
Sure can do |
ggazzo
reviewed
Jun 28, 2022
ggazzo
previously approved these changes
Jun 28, 2022
graywolf336
suggested changes
Jun 29, 2022
kodiakhq
bot
removed
the
stat: ready to merge
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
Created a fallback for when a release entry has no changelog. Now it shows a "No release information provided" text on the accordion item.
…pp-info-releases-tab
graywolf336
approved these changes
Jun 29, 2022
ggazzo
approved these changes
Jun 29, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Added a Releases tab to the app info page of installed marketplace apps. This tab will show all the released versions of a given app with its version number, release date in humanized form, and the changelog of this given release with the information provided by the publisher, this changelog accepts and renders markdown. Also refactored some component names and logic for maintainability reasons.
Demo gif:
Issue(s)
Steps to test or reproduce
Further comments