[FIX] Unable to close chats when comments is disabled #26057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murtaza98
changed the title
|
This is not a regression per se, but this would be a really annoying issue 😬 to keep on 5.0. @ggazzo , agree on put this as "regression" (it will go through normal QA anyways, but since the fix is pretty self contained, we should be good) |
MartinSchoeler
previously requested changes
Jun 30, 2022
apps/meteor/client/components/Omnichannel/modals/CloseChatModal.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/components/Omnichannel/modals/CloseChatModal.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat>
murtaza98
commented
Jul 1, 2022
apps/meteor/client/components/Omnichannel/modals/CloseChatModal.tsx
Outdated
Show resolved
Hide resolved
Done ✔️ , please check |
ggazzo
added
stat: ready to merge
aleksandernsilva
approved these changes
Jul 1, 2022
tassoevan
pushed a commit
that referenced
this pull request
Jul 1, 2022
Merged
KevLehman
pushed a commit
that referenced
this pull request
Jul 27, 2022
murtaza98
added a commit
that referenced
this pull request
Jul 29, 2022
Closed
murtaza98
added a commit
that referenced
this pull request
Aug 2, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Fixes #25954
Issue(s)
Steps to test or reproduce
Further comments