Chore: Fix Omnichannel E2E tests not running #26092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampaiodiego
requested changes
Jul 19, 2022
apps/meteor/.mocharc.api.js
Outdated
Comment on lines
17
to
18
| 'tests/end-to-end/api/livechat/*.js', | ||
| 'tests/end-to-end/api/livechat/*.ts', |
There was a problem hiding this comment.
I think it is better to use a greedy glob, something like:
'tests/end-to-end/api/**/*.js',
'tests/end-to-end/api/**/*.ts',
so it is not needed to have specific lines for livechat and whatever else we add
| @@ -287,7 +287,7 @@ export class LivechatVisitorsRaw extends BaseRaw<ILivechatVisitor> implements IL | |||
| } | |||
|
|
|||
| removeById(_id: string): Promise<DeleteResult> { | |||
| return this.removeById(_id); | |||
| return this.deleteOne({ _id }); | |||
There was a problem hiding this comment.
is this being used? I mean, glad you fixed since it is an infinite recursive loop, if this is being used somewhere how none found it before? 🙈
There was a problem hiding this comment.
Yeah, I believe this is getting used on Livechat when visitor requests to delete their data 🙈
There was a problem hiding this comment.
It's used as murtaza said. But as that feature is not that used 🙈 probably no one found it. (This single line could easily be a regression tho)
sampaiodiego
approved these changes
Jul 19, 2022
KevLehman
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments