Regression: Fix rendered markdown styling on app info page details section #26093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a problem where flexbox was wrongly used on the app details section of the app info page, which caused the rendered markdown to behave weirdly. Next I'll be solving the styling problem.
Fixed a bug in which the rendered markdown of the details section of the app info page wouldn't get its correct styles because of the global CSS reset. Added the withRichContent flag to the box that renders the markdown.
ggazzo
added
stat: ready to merge
ggazzo
approved these changes
Jul 12, 2022
gabriellsh
added a commit
that referenced
this pull request
Jul 12, 2022
…jumpMessage * 'develop' of github.com:RocketChat/Rocket.Chat: (27 commits) Chore: Remove unused migrations (#26102) Regression: Fix files list endpoints (#26226) Regression: Fix Omnichannel not working after meteor update (#26194) Regression: Empty URL previews in messages. (#26160) Regression: OTR with new React Messages (#26179) Regression: Replace contact center icon (#26216) Regression: Fix rendered markdown styling on app info page details section (#26093) [BREAK] Remove webRTC for channels/dm/groups (#26225) Regression: Meteor uses projection for its observes (#26223) Chore: Do not log integrations using `name` key (#26163) Chore: Check for env var values and not just if they are set (#26219) Regression: UIKit buttons auth user validation (#26171) Regression: Cannot logout when CallProvider is unregistered and mounted (#26158) Regression: Change Audio settings for device settings as modal title (#26159) Regression: Inline code and copyonly tag styles (#26173) Regression: remove italic from reaction translation (#26152) Regression: Reverting @rocket.chat/mp3-encoder version to fix Audio Message (#26197) Chore: Info page (#26201) Regression: Fix command previews (#26199) Change Apps-Engine version source for info (#26205) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Fixed two styling problems on the AppDetails markdown. The first one was a misuse of flex and the second was the fact that the withRichContent flag was missing on the box that received the markdown.
Demo images:
Before:
After:
Clickup task: https://app.clickup.com/t/2rwq0q7
Issue(s)
Steps to test or reproduce
Further comments