Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Parse outbound phone number removing * putting + char #26154

Merged
merged 8 commits into from
Jul 15, 2022

Conversation

tiagoevanp
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@tiagoevanp tiagoevanp requested review from a team as code owners July 6, 2022 18:02
@KevLehman
Copy link
Contributor

Opening the Omnichannel Directory seems to not to work on this PR 🤔

KevLehman
KevLehman previously approved these changes Jul 8, 2022
Copy link
Contributor

@KevLehman KevLehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional-wise, seems to be working 👀

@ggazzo ggazzo added this to the 5.0.0 milestone Jul 12, 2022
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jul 12, 2022
@tiagoevanp tiagoevanp dismissed stale reviews from aleksandernsilva and KevLehman via 0c0ccf7 July 13, 2022 17:32
@tiagoevanp tiagoevanp requested a review from ggazzo July 14, 2022 13:48
@ggazzo ggazzo merged commit e261012 into develop Jul 15, 2022
@ggazzo ggazzo deleted the regression/asterisk-phone branch July 15, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants