Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Change Audio settings for device settings as modal title #26159

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Regression: Change Audio settings for device settings as modal title #26159

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2126aab
Change Audio settings for device settings
KevLehman Jul 6, 2022
123d35e
Merge branch 'develop' into regression/change-modal-to-device-settings
murtaza98 Jul 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/meteor/ee/client/voip/modals/DeviceSettingsModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ const DeviceSettingsModal = (): ReactElement => {
return (
<Modal is='form' onSubmit={handleSubmit(onSubmit)}>
<Modal.Header>
<Modal.Title>{t('Audio_settings')}</Modal.Title>
<Modal.Title>{t('Device_settings')}</Modal.Title>
<Modal.Close onClick={onCancel} />
</Modal.Header>
<Modal.Content fontScale='p2'>
Expand Down
1 change: 0 additions & 1 deletion apps/meteor/packages/rocketchat-i18n/i18n/en.i18n.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,6 @@
"Audio_Notification_Value_Description": "Can be any custom sound or the default ones: beep, chelle, ding, droplet, highbell, seasons",
"Audio_Notifications_Default_Alert": "Audio Notifications Default Alert",
"Audio_Notifications_Value": "Default Message Notification Audio",
"Audio_settings": "Audio Settings",
"Audios": "Audios",
"Auditing": "Auditing",
"Auth_Token": "Auth Token",
Expand Down