Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove method meteor call on message action #26213

Merged
merged 16 commits into from
Dec 6, 2022

Conversation

filipemarins
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Remove method call on the message action component

@filipemarins filipemarins changed the title Chore: Remove method call on message action Chore: Remove method meteor call on message action Jul 11, 2022
Base automatically changed from chore/remove-method-call to develop August 12, 2022 20:50
@ggazzo ggazzo requested review from a team as code owners August 12, 2022 20:50
yash-rajpal
yash-rajpal previously approved these changes Aug 17, 2022
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #26213 (e72f74d) into develop (ccb8269) will increase coverage by 0.58%.
The diff coverage is 20.83%.

❗ Current head e72f74d differs from pull request most recent head 5ead742. Consider uploading reports for the commit 5ead742 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26213      +/-   ##
===========================================
+ Coverage    41.09%   41.68%   +0.58%     
===========================================
  Files          840      826      -14     
  Lines        18365    18263     -102     
  Branches      2106     1988     -118     
===========================================
+ Hits          7548     7613      +65     
+ Misses       10526    10361     -165     
+ Partials       291      289       -2     
Flag Coverage Δ
e2e 41.68% <20.83%> (+0.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

yash-rajpal
yash-rajpal previously approved these changes Aug 18, 2022
@ggazzo ggazzo added stat: QA skipped stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 18, 2022
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Sep 23, 2022
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Sep 23, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 11, 2022
@ggazzo ggazzo added this to the 6.0.0-pre milestone Nov 24, 2022
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Dec 5, 2022
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Dec 5, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: conflict labels Dec 6, 2022
@ggazzo ggazzo merged commit 146b096 into develop Dec 6, 2022
@ggazzo ggazzo deleted the chore/remove-meteor-call-message branch December 6, 2022 02:30
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants