Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Tests refactor pageobjects #26245

Merged
merged 28 commits into from
Jul 19, 2022
Merged

Chore: Tests refactor pageobjects #26245

merged 28 commits into from
Jul 19, 2022

Conversation

souzaramon
Copy link
Contributor

@souzaramon souzaramon commented Jul 13, 2022 •
edited
Loading

Proposed changes (including videos or screenshots)

  • Refactor page objects to a more "composable" strucutre
  • Remove some useless "render tests"
  • Update tests to use the new page objects

souzaramon added 14 commits July 13, 2022 07:33
chore: update e2e script name
f2b1741
refactor: remove useless constants
2238168
feat: add ADMIN_CREDENTIALS constant
6d3c066
feat: create better structured page-objects
906be14
test: update omnichannel-departaments suite to use new page-objects
a2b434e
test: update omnichannel-agents suite to use new page-objects
e171019
test: update forgot-password suite to use new page-objects
898c324
test: update register suite to use new page-objects
042e19c
test: update login suite to use new page-objects
f792470
test: update channel-creation suite to use new page-objects
a9405dc
test: update user-preferences suite to use new page-objects
f2e79c5
test: update message-popup suite to use new page-objects
9bb8e7b
test: update discussion suite to use new page-objects
cfd5d8b
chore: remove render tests
8080885
weslley543
weslley543 suggested changes Jul 13, 2022
View reviewed changes
apps/meteor/tests/e2e/01-forgot-password.spec.ts Show resolved Hide resolved
apps/meteor/tests/e2e/02-register.spec.ts Outdated Show resolved Hide resolved
apps/meteor/tests/e2e/02-register.spec.ts Show resolved Hide resolved
apps/meteor/tests/e2e/03-login.spec.ts Outdated Show resolved Hide resolved
@souzaramon souzaramon force-pushed the refactor/test-pageobjects branch from 9ee843e to 0b8f0c7 Compare July 14, 2022 13:41
@souzaramon souzaramon requested a review from weslley543 July 15, 2022 08:17
@souzaramon souzaramon force-pushed the refactor/test-pageobjects branch from a7ece53 to 882ed4d Compare July 15, 2022 08:50
weslley543
weslley543 suggested changes Jul 18, 2022
View reviewed changes
apps/meteor/tests/e2e/00-wizard.spec.ts Outdated Show resolved Hide resolved
apps/meteor/tests/e2e/00-wizard.spec.ts Outdated Show resolved Hide resolved
apps/meteor/tests/e2e/utils/mocks/urlMock.ts Outdated Show resolved Hide resolved
apps/meteor/tests/e2e/utils/mocks/waitSelectorsMock.ts Outdated Show resolved Hide resolved
apps/meteor/tests/e2e/00-wizard.spec.ts Show resolved Hide resolved
apps/meteor/tests/e2e/07-emoji.spec.ts Outdated Show resolved Hide resolved
apps/meteor/tests/e2e/10-user-preferences.spec.ts Show resolved Hide resolved
apps/meteor/tests/e2e/13-permissions.spec.ts Show resolved Hide resolved
apps/meteor/tests/e2e/16-discussion.spec.ts Outdated Show resolved Hide resolved
apps/meteor/tests/e2e/omnichannel-agents.spec.ts Outdated Show resolved Hide resolved
@weslley543 weslley543 marked this pull request as ready for review July 19, 2022 12:14
@weslley543 weslley543 requested a review from a team as a code owner July 19, 2022 12:14
@ggazzo ggazzo changed the title Chore: refactor test pageobjects Chore: Tests refactor pageobjects Jul 19, 2022
@ggazzo ggazzo merged commit 7933477 into develop Jul 19, 2022
@ggazzo ggazzo deleted the refactor/test-pageobjects branch July 19, 2022 14:10
weslley543 added a commit that referenced this pull request Jul 19, 2022
@weslley543
Chore: Tests refactor pageobjects (#26245)
c6663cb 
Co-authored-by: Weslley de Campos <weslley.campos@objective.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weslley543 weslley543 weslley543 approved these changes

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@souzaramon @ggazzo @weslley543